@releng better hlxignore #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove root json, - remove code coverage, - generic rule for sidekick like nested json
mokimo
approved these changes
Mar 28, 2024
3ch023
requested changes
Mar 28, 2024
There was a problem hiding this comment.
likely not related to the PR but the test branch returns 404:
https://hlxlignore--cc--npeltier.hlx.page/products/special-offers
is it the same for you?
|
@3ch023 there's a typo in the description, an extra "l" hlx-l-ignore |
sukamat
approved these changes
Mar 28, 2024
Ruchika4
approved these changes
Mar 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #253 +/- ##
==========================================
- Coverage 87.68% 87.32% -0.36%
==========================================
Files 9 9
Lines 934 947 +13
==========================================
+ Hits 819 827 +8
- Misses 115 120 +5 ☔ View full report in Codecov by Sentry. |
3ch023
approved these changes
Apr 3, 2024
aishwaryamathuria
added
the
ready for main
aishwaryamathuria
added a commit
that referenced
this pull request
Apr 15, 2024
Merging following PRs to main - #246 MWPW-143951 | Optimize sidenav #253 Better hlxignore #257 MWPW-145840 | Fixing enticement for RTL locale in page of genfill #263 MWPW-142006 | Enable repo-sync for graybox ---------------------------------- Interactive-Metadata ---------------------------------- #251 MWPW-142971 | Interactive web components over Marquee and Aside #264 MWPW-146229 | Integrating review comments and new workflows for Interactive metadata #265 MWPW-146219 | Hue Sat fix upload image icon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test URLs: