Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 514 improve name for email fatigue scores in experience event #515

Conversation

cdegroot-adobe
Copy link
Contributor

Please link to the issue #514

Renamed the xdm:email property to xdm:emailScore.

Added omitted examples

- Renamed `xdm:email` to `xdm:emailScore'
Added examples from that were omitted from the prior PR.
"xdm:status": "realized"
}
],
"xdm:emailScores": {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume xdm:emailScores column will be inside the xdm:journeyAI object.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @josemathew! @cdegroot-adobe the example you posted missed the "journeyAI" sub-object in profile, can you fix before we merge?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kstreeter . @cdegroot-adobe column should be xdm:emailScore, as defined in the schema definition

@josemathew
Copy link

@cdegroot-adobe Thanks for adding examples for the Journey AI schemas. Renaming the column name from email to emailScore looks good to me.

@cdegroot-adobe
Copy link
Contributor Author

@kstreeter - I have corrected the example

@kstreeter kstreeter merged commit d66c338 into master Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants