-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Journey AI Fatigue and Score schemas #492
Conversation
], | ||
"$id": "https://ns.adobe.com/experience/campaign/journeyaifatigue", | ||
"$schema": "http://json-schema.org/draft-06/schema#", | ||
"title": "Journey AI Fatigue", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while this is part of an Adobe extension - is the naming here too product and use specific?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will change the title to be less specific about Journey AI. Should I have to change the id ( journeyaifatigue
) as well?
"description": "Fatigue score for the profile", | ||
"$ref": "https://ns.adobe.com/experience/campaign/journeyaifatigue" | ||
}, | ||
"xdm:openScoresBySendHourForWeek": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will customers understand this, because I do not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We just wanted to add some context about the scores ( that they for a week, 24x7 scores ). I think title and description can be used for that, and I will rename the fields as openScores
and clickScores
@josemathew - Are you wanting these new schemas to be referenced by a new ExpereienceEvent campaign extension field - if so you will need to add a new field to the /extension/experience/campaign/experienceevent.schema.json file as well. |
@cmathis I will checking in a Profle schema extension today. |
Merging to update the example failing the test
Looks good to me. I am OK with merging it. @kstreeter , you? |
@kstreeter please include this PR in 0.9.6. |
"definitions": { | ||
"profile": { | ||
"properties": { | ||
"https://ns.adobe.com/experience/campaign/journeyai/email": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than putting this in a namespace, it would probably be better to either create a journeyAI sub-object, or perhaps just call this field emailJourneyAI or similar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kstreeter I will create a sub-object and add email field into it.
Hi @josemathew, can you take a look at #515, @cdegroot-adobe had a few additional comments on the PR and has proposed some small changes. Let us know if you have any concerns! |
PR to add 2 new schemas and profile extension in campaign namespace. Issue #491