Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Journey AI Fatigue and Score schemas #492

Merged
merged 11 commits into from
Sep 14, 2018

Conversation

josemathew
Copy link

@josemathew josemathew commented Aug 24, 2018

PR to add 2 new schemas and profile extension in campaign namespace. Issue #491

@josemathew josemathew changed the title JSON Schemas for Journey AI Fatigue and Score schemas Journey AI Fatigue and Score schemas Aug 24, 2018
],
"$id": "https://ns.adobe.com/experience/campaign/journeyaifatigue",
"$schema": "http://json-schema.org/draft-06/schema#",
"title": "Journey AI Fatigue",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while this is part of an Adobe extension - is the naming here too product and use specific?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will change the title to be less specific about Journey AI. Should I have to change the id ( journeyaifatigue ) as well?

"description": "Fatigue score for the profile",
"$ref": "https://ns.adobe.com/experience/campaign/journeyaifatigue"
},
"xdm:openScoresBySendHourForWeek": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will customers understand this, because I do not.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just wanted to add some context about the scores ( that they for a week, 24x7 scores ). I think title and description can be used for that, and I will rename the fields as openScores and clickScores

@cmathis
Copy link
Collaborator

cmathis commented Aug 27, 2018

@josemathew - Are you wanting these new schemas to be referenced by a new ExpereienceEvent campaign extension field - if so you will need to add a new field to the /extension/experience/campaign/experienceevent.schema.json file as well.

@josemathew
Copy link
Author

@cmathis I will checking in a Profle schema extension today.

@lrosenthol
Copy link
Collaborator

Looks good to me. I am OK with merging it. @kstreeter , you?

@cfraser
Copy link
Contributor

cfraser commented Sep 10, 2018

@kstreeter please include this PR in 0.9.6.

@kstreeter kstreeter added this to the 0.9.6 milestone Sep 11, 2018
"definitions": {
"profile": {
"properties": {
"https://ns.adobe.com/experience/campaign/journeyai/email": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than putting this in a namespace, it would probably be better to either create a journeyAI sub-object, or perhaps just call this field emailJourneyAI or similar.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kstreeter I will create a sub-object and add email field into it.

@kstreeter kstreeter merged commit 88c65b7 into adobe:master Sep 14, 2018
@josemathew josemathew deleted the journeyai-extensions branch September 17, 2018 18:06
@kstreeter
Copy link
Collaborator

Hi @josemathew, can you take a look at #515, @cdegroot-adobe had a few additional comments on the PR and has proposed some small changes. Let us know if you have any concerns!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants