[#225] Add sp-search
#235
Merged
[#225] Add sp-search
#235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Westbrook
force-pushed
the
westbrook/225/search
branch
from
01d90f9 to
dcf7767
Compare
Westbrook
commented
Oct 8, 2019
| @@ -7,7 +7,7 @@ export const ComponentApiDocs = new Map<string, TemplateResult>(); | |||
|
|
|||
| for (const key of componentApiDocs.keys()) { | |||
| const componentName = /([a-zA-Z-]+)\.html$/.exec(key)![1]; | |||
| const templateString = toHtmlTemplateString(componentApiDocs(key)); | |||
| const templateString = toHtmlTemplateString(componentApiDocs(key).default); | |||
There was a problem hiding this comment.
Not sure when this broke, but without it we get [object Module] instead of API docs...
| @@ -9,6 +9,9 @@ for (const key of componentDocs.keys()) { | |||
| if (!/node_modules/.test(key)) { | |||
| let componentName = key.split('/')[1]; | |||
| const fileName = /([a-zA-Z-]+)\.md$/.exec(key)![0]; | |||
| if (fileName === 'CHANGELOG.md') { | |||
| continue; | |||
| } | |||
There was a problem hiding this comment.
We now get automatic CHANGELOG.md generation, and they shouldn't be added to the docs site.
| @@ -53,5 +53,250 @@ module.exports = { | |||
| }, | |||
| ], | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
The following adds all of the UIIcon CSS to the icon package.
msdewey
reviewed
Oct 9, 2019
| }} | ||
| ></sp-search> | ||
| <sp-search disabled></sp-search> | ||
| ` |
There was a problem hiding this comment.
would it be possible to also get the quiet version in storybook?
| const applyDefault = this.dispatchEvent( | ||
| new Event('submit', { | ||
| cancelable: true, | ||
| bubbles: true, |
[#156] Add UIIcons styling from Spectrum CSS
|
Merged down into the branch, so it wants another review to "be sure..." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the
sp-searchelement.To-do:
formsearcheventUIIconstyles available in the system #156 in this PR or separately.masterRelated Issue
Fixes #225
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: