Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make UIIcon styles available in the system #156

Closed
Westbrook opened this issue Aug 23, 2019 · 2 comments
Closed

Make UIIcon styles available in the system #156

Westbrook opened this issue Aug 23, 2019 · 2 comments

Comments

@Westbrook
Copy link
Contributor

Expected Behaviour

Icons can be sized as icon but also as uiicon for use in more intricate situations.

Actual Behaviour

When only icon is available patterns like <sp-dropdow invalid /> are not correctly supported.

Current

image
image

Expected

image
image
@Westbrook Westbrook mentioned this issue Aug 23, 2019
Merged
10 tasks
@Westbrook
Copy link
Contributor Author

This also prevents adopting accurate locations for this like https://github.com/adobe/spectrum-web-components/pull/177/files#r322515512 out of the Spectrum CSS Custom Property collection.

@Westbrook Westbrook mentioned this issue Sep 10, 2019
Merged
8 tasks
This was referenced Oct 4, 2019
Merged
Merged
Westbrook pushed a commit that referenced this issue Oct 9, 2019
Merge pull request #239 from adobe/westbrook/UIIcons
8c4fe78 
[#156] Add UIIcons styling from Spectrum CSS
@Westbrook
Copy link
Contributor Author

fixed in #235

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Westbrook