Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Remove unnecessary extrakey for CodeMirror #2039

Merged
merged 1 commit into from
Nov 5, 2012
Merged

Remove unnecessary extrakey for CodeMirror #2039

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/editor/Editor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,9 +320,6 @@ define(function (require, exports, module) {
"Esc": function (instance) {
self.removeAllInlineWidgets();
},
"Shift-Delete": "cut",
"Ctrl-Insert": "copy",
"Shift-Insert": "paste",
"'>'": function (cm) { cm.closeTag(cm, '>'); },
"'/'": function (cm) { cm.closeTag(cm, '/'); }
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, these shortcuts work on Win7, but not Mac 10.6, for me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But is that the same both before and after this change? If so then it should be safe to remove...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should be transparent. It never added new shortcuts for Brackets. What copy, cut and paste shortcuts are depends on the OS.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I verified that those shortcuts still work on Win7 in this branch. Good catch!

Expand Down