This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Remove unnecessary extrakey for CodeMirror #2039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| @@ -320,9 +320,6 @@ define(function (require, exports, module) { | |||
| "Esc": function (instance) { | |||
| self.removeAllInlineWidgets(); | |||
| }, | |||
| "Shift-Delete": "cut", | |||
| "Ctrl-Insert": "copy", | |||
| "Shift-Insert": "paste", | |||
There was a problem hiding this comment.
FYI, these shortcuts work on Win7, but not Mac 10.6, for me.
There was a problem hiding this comment.
But is that the same both before and after this change? If so then it should be safe to remove...
There was a problem hiding this comment.
This change should be transparent. It never added new shortcuts for Brackets. What copy, cut and paste shortcuts are depends on the OS.
There was a problem hiding this comment.
OK, I verified that those shortcuts still work on Win7 in this branch. Good catch!
|
Looks good. Merging. |
redmunds
added a commit
that referenced
this pull request
Nov 5, 2012
Remove unnecessary extrakey for CodeMirror
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CodeMirror do not have "copy", "cut" and "paste" commands. These extrakeys are ignored by CodeMirror.