Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

Implement node-module add-on for native Windows file watching #413

Merged
merged 3 commits into from
Jan 31, 2014

Conversation

bchintx
Copy link
Contributor

@bchintx bchintx commented Jan 29, 2014

Fixes brackets issue #6551- "[File Watchers] Can not externally rename a directory with subfolders on Windows"

Requires associated pull request #6686 from brackets repo.

Calling a native node-module add-on in Windows requires that the node process be named "node.exe", rather than our renamed "Brackets-node.exe". This change reverts our previous renaming so that we ship with "node.exe" instead.

NOTE: this pull request against the release branch replaces the earlier PR #412 against master.

@bchintx
Copy link
Contributor Author

bchintx commented Jan 29, 2014

I've reviewed Jeff's changes and they look great. I'm fine with merging this change just as soon as PR #6686 is reviewed and ready to merge.

@ghost ghost assigned bchintx Jan 29, 2014
@redmunds
Copy link
Contributor

I see more references to "Brackets-node" when I search brackets-shell:

  C:\Users\redmunds\github\brackets-shell\Brackets.vcxproj(406):    <CustomBuild Include="deps\node\Brackets-node.exe">
  C:\Users\redmunds\github\brackets-shell\Brackets.vcxproj(408):      <Command>call mkdir &quot;$(OutDir)&quot; 2&gt;nul &amp; set ERRORLEVEL=0 &amp; copy /Y &quot;deps\node\Brackets-node.exe&quot; &quot;$(OutDir)Brackets-node.exe&quot;</Command>
  C:\Users\redmunds\github\brackets-shell\Brackets.vcxproj(409):      <Message>Copying deps/node/Brackets-node.exe to $(OutDir)\Brackets-node.exe</Message>
  C:\Users\redmunds\github\brackets-shell\Brackets.vcxproj(410):      <Outputs>$(OutDir)\Brackets-node.exe</Outputs>
  C:\Users\redmunds\github\brackets-shell\Brackets.vcxproj.filters(31):    <None Include="deps\node\Brackets-node.exe">
  C:\Users\redmunds\github\brackets-shell\deps\cef\Release\dev\src\filesystem\impls\appshell\node\FileWatcherDomain.js(52): * the fsevents module is compiled by default for x86-64, but the Brackets-node
  C:\Users\redmunds\github\brackets-shell\Release\dev\src\filesystem\impls\appshell\node\FileWatcherDomain.js(52): * the fsevents module is compiled by default for x86-64, but the Brackets-node

UPDATE: Sorry, I should have cleaned that up before I pasted it in.

@bchintx
Copy link
Contributor Author

bchintx commented Jan 30, 2014

@JeffryBooher did you want to respond to @redmunds comment? My response would be that we don't need to change all name instances since this is a Windows-only (and possibly a temporary) fix.

@redmunds
Copy link
Contributor

Sorry, I pasted that list before I cleaned it up. The only references I'm concerned about are the ones in Brackets.vcxproj

@JeffryBooher
Copy link
Contributor

@redmunds did you run grunt setup?

@redmunds
Copy link
Contributor

No. That was it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants