This repository has been archived by the owner on Sep 2, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 614
Implement node-module add-on for native Windows file watching #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 29, 2014
I've reviewed Jeff's changes and they look great. I'm fine with merging this change just as soon as PR #6686 is reviewed and ready to merge. |
ghost
assigned bchintx
Jan 29, 2014
I see more references to "Brackets-node" when I search brackets-shell:
UPDATE: Sorry, I should have cleaned that up before I pasted it in. |
@JeffryBooher did you want to respond to @redmunds comment? My response would be that we don't need to change all name instances since this is a Windows-only (and possibly a temporary) fix. |
Sorry, I pasted that list before I cleaned it up. The only references I'm concerned about are the ones in Brackets.vcxproj |
@redmunds did you run |
No. That was it. |
bchintx
added a commit
that referenced
this pull request
Jan 31, 2014
Implement node-module add-on for native Windows file watching
bchintx
added a commit
that referenced
this pull request
Dec 8, 2015
Implement node-module add-on for native Windows file watching
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brackets issue #6551- "[File Watchers] Can not externally rename a directory with subfolders on Windows"
Requires associated pull request #6686 from brackets repo.
Calling a native node-module add-on in Windows requires that the node process be named "node.exe", rather than our renamed "Brackets-node.exe". This change reverts our previous renaming so that we ship with "node.exe" instead.
NOTE: this pull request against the
release
branch replaces the earlier PR #412 againstmaster
.