[CLOSED] [REVIEW-ONLY] Implement node-module add-on for native Windows file watching

[core-ai-bot]

Issue by bchintx
Tuesday Jan 28, 2014 at 22:13 GMT
Originally opened as adobe#412

---

Fixes brackets issue #6551- "[File Watchers] Can not externally rename a directory with subfolders on Windows"

Requires associated pull request #6673 from brackets repo.

Calling a native node-module add-on in Windows requires that the node process be named "node.exe", rather than our renamed "Brackets-node.exe". This change reverts our previous renaming so that we ship with "node.exe" instead.

---

bchintx included the following code: https://github.com/adobe/brackets-shell/pull/412/commits

[core-ai-bot]

Comment by jasonsanjose
Tuesday Jan 28, 2014 at 22:25 GMT

---

@bchintx this pull request targets master. Is that right or should it be release?

[core-ai-bot]

Comment by bchintx
Tuesday Jan 28, 2014 at 23:08 GMT

---

oh, hey! Good catch, @jasonsanjose . Yes, before merging, I'll re-submit this to release instead.

[core-ai-bot]

Comment by bchintx
Wednesday Jan 29, 2014 at 16:59 GMT

---

Closing this pull request to re-submit against the release branch.

[core-ai-bot]

Comment by iwehrman
Wednesday Jan 29, 2014 at 17:41 GMT

---

It would be easy and helpful to also set the Node process title back to something unique from within appshell/node-core, probably in Launcher.js:

process.title = "Brackets-Node";

[core-ai-bot]

Comment by bchintx
Wednesday Jan 29, 2014 at 17:43 GMT

---

FYI...submitted Pull Request #413 to replace this one.

[core-ai-bot]

Comment by bchintx
Wednesday Jan 29, 2014 at 17:46 GMT

---

@iwehrman Good observation. Actually @JeffryBooher tried that suggestion but it doesn't work on Windows, which is where we're having the issue. Even with that change, TaskManager continues to show the actual filename.

[core-ai-bot]

Comment by iwehrman
Wednesday Jan 29, 2014 at 17:50 GMT

---

Yes, but it helps differentiate the process on Mac and Linux at least. It's just a convenience for when you ps and find a bunch of node processes.

[core-ai-bot]

Comment by iwehrman
Wednesday Jan 29, 2014 at 17:52 GMT

---

(Plus it seems like the kind of thing that Node will get around to fixing on Windows eventually.)
(Plus it's easy.)

[core-ai-bot]

Comment by ingorichter
Wednesday Jan 29, 2014 at 17:53 GMT

---

I agree with Ian. We should do this anyway. It doesn't do any harm and helps at least on 2 out of 3 supported platforms.

[core-ai-bot]

Comment by iwehrman
Wednesday Jan 29, 2014 at 17:55 GMT

---

You know what they say: two outta three ain't bad!

[core-ai-bot]

Comment by bchintx
Wednesday Jan 29, 2014 at 22:09 GMT

---

@iwehrman @ingorichter
I understand your concerns, but please note that this change is only for Windows. The Mac binary is still "Brackets-node", just like it was before.