PDCL-1333 - remove event name validation logic #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think these test failures are from my code changes–it looks like there was some kind of SauceLabs connection failure. |
jfkhoury
approved these changes
Feb 9, 2022
shammowla
approved these changes
Feb 9, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The JIRA ticket states that customers are getting confused by the warning when sending an event without an
eventType. According to Daniel Vivas, event types are always optional and currently only used by Platform. Therefore, I think that there isn't any harm in just removing the logic that warns the user when there isn't aneventType.Related Issue
PDCL-1333
Types of changes
Checklist: