PDCL-1333 - remove event name validation logic (#804)

Author: carterworks

src/components/DataCollector/index.js

@@ -12,13 +12,13 @@ governing permissions and limitations under the License.
 
 import validateUserEventOptions from "./validateUserEventOptions";
 
-const createDataCollector = ({ eventManager, logger }) => {
+const createDataCollector = ({ eventManager }) => {
   return {
     commands: {
       sendEvent: {
         documentationUri: "https://adobe.ly/2r0uUjh",
         optionsValidator: options => {
-          return validateUserEventOptions({ options, logger });
+          return validateUserEventOptions({ options });
         },
         run: options => {
           const {

src/components/DataCollector/validateUserEventOptions.js

@@ -15,10 +15,9 @@ import { validateIdentityMap } from "../../utils";
 /**
  * Verifies user provided event options.
  * @param {*} options The user event options to validate
- * @param {*} logger
  * @returns {*} Validated options
  */
-export default ({ options, logger }) => {
+export default ({ options }) => {
   const eventOptionsValidator = objectOf({
     type: string(),
     xdm: objectOf({
@@ -30,10 +29,5 @@ export default ({ options, logger }) => {
     decisionScopes: arrayOf(string()),
     datasetId: string()
   }).required();
-  const validatedOptions = eventOptionsValidator(options);
-  const { type, xdm } = validatedOptions;
-  if (xdm && !xdm.eventType && !type) {
-    logger.warn("No type or xdm.eventType specified.");
-  }
-  return validatedOptions;
+  return eventOptionsValidator(options);
 };

test/unit/specs/components/DataCollector/index.spec.js

@@ -14,7 +14,6 @@ import { noop } from "../../../../../src/utils";
 
 describe("Event Command", () => {
   let event;
-  let logger;
   let eventManager;
   let sendEventCommand;
   beforeEach(() => {
@@ -25,7 +24,6 @@ describe("Event Command", () => {
       "mergeXdm",
       "mergeMeta"
     ]);
-    logger = jasmine.createSpyObj("logger", ["warn"]);
 
     eventManager = {
       createEvent() {
@@ -40,8 +38,7 @@ describe("Event Command", () => {
     };
 
     const dataCollector = createDataCollector({
-      eventManager,
-      logger
+      eventManager
     });
     sendEventCommand = dataCollector.commands.sendEvent;
   });

test/unit/specs/components/DataCollector/validateUserEventOptions.spec.js

@@ -56,42 +56,4 @@ describe("DataCollector::validateUserEventOptions", () => {
       }).toThrowError();
     });
   });
-  it("logs warning when event type is required and missing", () => {
-    const options = { xdm: { test: "" } };
-    const logger = {
-      warn: jasmine.createSpy()
-    };
-    validateUserEventOptions({ options, logger });
-    expect(logger.warn).toHaveBeenCalledWith(
-      "No type or xdm.eventType specified."
-    );
-  });
-  it("does not throw errors when event options are valid", () => {
-    [
-      {},
-      { xdm: { eventType: "test" } },
-      { type: "test", xdm: { test: "" } },
-      { renderDecisions: true },
-      { data: { test: "" } },
-      { renderDecisions: true, data: { test: "" } },
-      { decisionScopes: ["test"] },
-      { datasetId: "12432ewfr12" },
-      {
-        xdm: {
-          eventType: "test",
-          identityMap: {
-            namespace1: [
-              { id: "123", primary: true, authenticatedState: "authenticated" },
-              { id: "3" }
-            ],
-            namespace2: [{ id: "23", authenticatedState: "ambiguous" }]
-          }
-        }
-      }
-    ].forEach(options => {
-      expect(() => {
-        validateUserEventOptions({ options });
-      }).not.toThrowError();
-    });
-  });
 });