Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tabs] Redefine active item logic #378

Closed
richardhand opened this issue Nov 14, 2018 · 0 comments
Closed

[Tabs] Redefine active item logic #378

richardhand opened this issue Nov 14, 2018 · 0 comments
Labels
bug Unexpected problem or unintended behavior that impairs normal functioning of the product.
Milestone
2.2.2

Comments

@richardhand
Copy link
Contributor

richardhand commented Nov 14, 2018 •
edited
Loading

Change the way that an active item is defined such that it's not based on the path of the child item, the main motivation being a clean JSON output that doesn't expose such paths (see #298).

Keep the activeItem property on the Tabs parent and rather than providing a path, return the resource name (item_2 etc.) of the active item in the Tabs Sling Model.

CQ-4257502
@richardhand richardhand added the bug Unexpected problem or unintended behavior that impairs normal functioning of the product. label Nov 14, 2018
@richardhand richardhand added this to the 2.2.2 milestone Nov 14, 2018
@richardhand richardhand mentioned this issue Nov 14, 2018
Merged
richardhand added a commit that referenced this issue Nov 16, 2018
@richardhand
#376 [Tabs][Carousel] Panel title should not override child item title
709a454 
* #378 [Tabs] Redefine active item logic
richardhand added a commit that referenced this issue Nov 20, 2018
@richardhand
#376 [Tabs][Carousel] Panel title should not override child item title
8042f14 
* #378 [Tabs] Redefine active item logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Unexpected problem or unintended behavior that impairs normal functioning of the product.
Projects
None yet
Milestone
2.2.2
Development

No branches or pull requests
2 participants
@andreeadracea @richardhand