Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tabs][Carousel] Panel title should not override child item title #376

Closed
richardhand opened this issue Nov 14, 2018 · 0 comments
Closed

[Tabs][Carousel] Panel title should not override child item title #376

richardhand opened this issue Nov 14, 2018 · 0 comments
Labels
bug Unexpected problem or unintended behavior that impairs normal functioning of the product.
Milestone
2.2.2

Comments

@richardhand
Copy link
Contributor

For both the Tabs and Carousel components we currently override the jcr:title property of the child components when setting an item/panel title. It's therefore not possible to have exclusive titles for the item and for the component if the title is read from the same location. As well as being inflexible, this could be confusing for authors as it's easy to accidentally override the component title via the dialog.

Proposal is to instead write a unique namespaced property cmp:panelTitle to the component nodes. The items should read this property and if it doesn't exist fall back to the jcr:title.

CQ-4257499
@richardhand richardhand added the bug Unexpected problem or unintended behavior that impairs normal functioning of the product. label Nov 14, 2018
@richardhand richardhand added this to the 2.2.2 milestone Nov 14, 2018
richardhand added a commit that referenced this issue Nov 14, 2018
@richardhand
#376 [Tabs][Carousel] Panel title should not override child item title
1ce0c9a
@richardhand richardhand mentioned this issue Nov 14, 2018
Merged
richardhand added a commit that referenced this issue Nov 14, 2018
@richardhand
#376 [Tabs][Carousel] Panel title should not override child item title
6ec2c1e
richardhand added a commit that referenced this issue Nov 14, 2018
@richardhand
#376 [Tabs][Carousel] Panel title should not override child item title
76e3992
richardhand added a commit that referenced this issue Nov 15, 2018
@richardhand
#376 [Tabs][Carousel] Panel title should not override child item title
9df1917
richardhand added a commit that referenced this issue Nov 15, 2018
@richardhand
#376 [Tabs][Carousel] Panel title should not override child item title
577dca9 
- removes erroneous comment
richardhand added a commit that referenced this issue Nov 15, 2018
@richardhand
#376 [Tabs][Carousel] Panel title should not override child item title
1360c40
richardhand added a commit that referenced this issue Nov 15, 2018
@richardhand
#376 [Tabs][Carousel] Panel title should not override child item title
e8a3d8f
richardhand added a commit that referenced this issue Nov 16, 2018
@richardhand
#376 [Tabs][Carousel] Panel title should not override child item title
ec57a83
richardhand added a commit that referenced this issue Nov 16, 2018
@richardhand
#376 [Tabs][Carousel] Panel title should not override child item title
709a454 
* #378 [Tabs] Redefine active item logic
richardhand added a commit that referenced this issue Nov 20, 2018
@richardhand
#376 [Tabs][Carousel] Panel title should not override child item title
8042f14 
* #378 [Tabs] Redefine active item logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Unexpected problem or unintended behavior that impairs normal functioning of the product.
Projects
None yet
Milestone
2.2.2
Development

No branches or pull requests
2 participants
@andreeadracea @richardhand