feat: use rum js v2 #371

kptdobe · 2024-06-19T14:27:24Z

Migration to rum js v2. A lot of checkpoints are not required anymore.

The aem.js in this PR would come from adobe/aem-lib#76, it does not need to be committed, but it is here to be able to test.

Test page: https://migration-rum-js-v2--aem-boilerplate--adobe.aem.live/?rum=on

aem-code-sync · 2024-06-19T14:27:28Z

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

Re-run PSI checks
Re-sync branch

Commits

3409d7c ✅ (latest)
e150047 ✅
4410891 ✅
23da3fc ✅
6d99a2c ✅

aem-code-sync · 2024-06-19T14:27:43Z

Page	Scores	Audits	Google
/?rum=on

404.html

trieloff · 2024-06-21T10:35:25Z

scripts/aem.js

-    sampleRUM('error', { source: event.filename, target: event.lineno });
-  });
+  sampleRUM();
+  window.addEventListener('hlx:section:loaded', sampleRUM.enhance, { once: true });


Suggested change

window.addEventListener('hlx:section:loaded', sampleRUM.enhance, { once: true });

window.addEventListener('aem:section:loaded', sampleRUM.enhance, { once: true });

To be discussed, there is the idea that hlx namespace could be "internal" (i.e. do not rely on it, can change), aem being public (i.e. backward comp)...

trieloff · 2024-06-21T10:35:36Z

scripts/aem.js

@@ -533,6 +512,7 @@ function updateSectionsStatus(main) {
      } else {
        section.dataset.sectionStatus = 'loaded';
        section.style.display = null;
+        window.dispatchEvent(new CustomEvent('hlx:section:loaded', { detail: { section } }));


Suggested change

window.dispatchEvent(new CustomEvent('hlx:section:loaded', { detail: { section } }));

window.dispatchEvent(new CustomEvent('aem:section:loaded', { detail: { section } }));

trieloff · 2024-06-21T10:36:06Z

No re-review required.

Co-authored-by: Lars Trieloff <lars@trieloff.net>

* add css rules to hide header and footer until they are loaded * chore(deps): update dependency stylelint to v16.1.0 (adobe#314) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency stylelint-config-standard to v36 (adobe#315) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency chai to v5 (adobe#316) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @babel/core to v7.23.7 (adobe#317) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency semantic-release to v23 (adobe#320) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: update node version (adobe#321) * chore: update node version * chore: use node 20 * chore: get rid of semantic release (adobe#322) * fix(lib): update scripts/aem.js to aem.js@1.5.1 Test URL: https://update-lib-aem-patch-1-5-1--aem-boilerplate--adobe.hlx.live/ Release Notes: https://github.com/adobe/aem-lib/releases/tag/v1.5.1 * chore(doc): link to cli in README (adobe#330) * chore(deps): update dependency stylelint to v16.2.1 (adobe#324) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency chai to v5.1.0 (adobe#328) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update babel monorepo (adobe#329) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency eslint to v8.57.0 (adobe#333) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency stylelint to v16.3.1 (adobe#341) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update babel monorepo (adobe#340) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update cleanup-on-create.yaml * Update cleanup-on-create.yaml * Update cleanup-on-create.yaml * chore(deps): update dependency @babel/core to v7.24.4 (adobe#342) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix: header/footer fragment loading (#13) * chore: unify header/footer decoration * fix(lib): update scripts/aem.js to aem.js@1.5.4 Test URL: https://update-lib-aem-patch-1-5-4--aem-boilerplate--adobe.hlx.live/ Release Notes: https://github.com/adobe/aem-lib/releases/tag/v1.5.4 * fix: cards fail if text contains an icon * fix(404): do not include target, as it is redundant with URL * fix: clarify eslint rules * feat: add quote parity with eslint in stylelint * chore: lint * fix: remove unused rule * fix: remove deprecated root var * feat: added updated fonts * fix: apply s2 font styles * fix: increase body font size * chore: unify color vars against s2 spec * fix: increase color contrast between bg and link * fix: increase contrast between link and text * fix: unify container padding, margins, radius * chore(deps): update dependency stylelint to v16.6.1 (adobe#356) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update babel monorepo to v7.24.6 (adobe#358) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency chai to v5.1.1 (adobe#360) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update babel monorepo to v7.24.7 (adobe#367) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix: link color meets background AND text contrast reqs * chore: remove unused dep (adobe#368) * fix: close the nav when it loses focus, e.g keyboard user tabs out of it * fix: manual patch of sampleRUM (adobe#370) * feat: better error tracking (adobe#375) * feat(lib): update scripts/aem.js to aem.js@2.3.0 (adobe#378) Test URL: https://update-lib-aem-minor-2-3-0--aem-boilerplate--adobe.hlx.live/ Release Notes: https://github.com/adobe/aem-lib/releases/tag/v2.3.0 Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net> * feat: section loader * chore(deps): update dependency stylelint to v16.7.0 (adobe#381) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @babel/eslint-parser to v7.24.8 (adobe#380) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency stylelint-config-standard to v36.0.1 (adobe#373) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(lib): update scripts/aem.js to aem.js@2.5.0 (adobe#383) Test URL: https://update-lib-aem-minor-2-5-0--aem-boilerplate--adobe.hlx.live/ Release Notes: https://github.com/adobe/aem-lib/releases/tag/v2.5.0 Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net> * feat: use rum js v2 (adobe#371) * fix: a11y contrast fix * chore: lint * fix: a styles * chore: lint * chore: a11y colors * fix: border color on cards * fix: a11y header, ul > li role * fix(lib): update scripts/aem.js to aem.js@2.5.1 (adobe#388) Test URL: https://update-lib-aem-patch-2-5-1--aem-boilerplate--adobe.hlx.live/ Release Notes: https://github.com/adobe/aem-lib/releases/tag/v2.5.1 Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net> * chore(deps): update dependency @babel/eslint-parser to v7.25.1 (adobe#385) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency stylelint to v16.8.1 (adobe#386) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: add editor config (adobe#353) * updating url to .aem.live from .hlx.live * docs: updating the preview and live urls in readme to .aem.page and .aem.live * fix(lib): update scripts/aem.js to aem.js@2.5.2 (adobe#391) Test URL: https://update-lib-aem-patch-2-5-2--aem-boilerplate--adobe.hlx.live/ Release Notes: https://github.com/adobe/aem-lib/releases/tag/v2.5.2 Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net> * chore(deps): update dependency stylelint to v16.8.2 (adobe#389) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * docs(readme): use correct AEM Live link * chore(github): update pull request template to use aem.live * Squashed 'plugins/aem-assets-plugin/' content from commit 2bf7be5 git-subtree-dir: plugins/aem-assets-plugin git-subtree-split: 2bf7be5876c039f3d22fcde65401635b7410f1cc * feat: Integrate asem-assets plugin * Add linting exception for videojs * Ignore videojs from linting --------- Co-authored-by: Sean Steimer <ssteimer@adobe.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Tobias Bocanegra <tripod@adobe.com> Co-authored-by: Alexandre Capt <acapt@adobe.com> Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net> Co-authored-by: dylandepass <djdyland@gmail.com> Co-authored-by: Katie Sexton <ksexton@adobe.com> Co-authored-by: gargadobe <81246588+gargadobe@users.noreply.github.com> Co-authored-by: Dirk Rudolph <drudolph@adobe.com> Co-authored-by: Lars Trieloff <lars@trieloff.net> Co-authored-by: adobe-bot <30273922+adobe-bot@users.noreply.github.com> Co-authored-by: David Nuescheler <uncled@adobe.com> Co-authored-by: Simon Sippert <simon.sippert@gmx.de> Co-authored-by: Kiran Murugulla <murugull@adobe.com> Co-authored-by: Satya Deep Maheshwari <satyam@adobe.com>

feat: use rum js v2

6d99a2c

kptdobe requested review from trieloff and davidnuescheler June 19, 2024 14:27

trieloff approved these changes Jun 21, 2024

View reviewed changes

fix: remove duplicate info

23da3fc

Co-authored-by: Lars Trieloff <lars@trieloff.net>

aem-code-sync bot temporarily deployed to migration-rum-js-v2 June 26, 2024 06:44 Inactive

kptdobe mentioned this pull request Jun 27, 2024

feat: rum essentials #375

Merged

fix: enhance post LCP

4410891

aem-code-sync bot temporarily deployed to migration-rum-js-v2 July 11, 2024 09:24 Inactive

Merge branch 'main' into migration-rum-js-v2

e150047

aem-code-sync bot temporarily deployed to migration-rum-js-v2 July 16, 2024 12:28 Inactive

Merge branch 'main' into migration-rum-js-v2

3409d7c

aem-code-sync bot deployed to migration-rum-js-v2 July 16, 2024 12:34 View deployment

kptdobe merged commit 8f226c2 into main Jul 16, 2024
3 checks passed

kptdobe deleted the migration-rum-js-v2 branch July 16, 2024 12:34

ramboz pushed a commit to ramboz/aem-boilerplate that referenced this pull request Jul 23, 2024

feat: use rum js v2 (adobe#371)

85a639a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: use rum js v2 #371

feat: use rum js v2 #371

kptdobe commented Jun 19, 2024

aem-code-sync bot commented Jun 19, 2024 •

edited

Loading

aem-code-sync bot commented Jun 19, 2024 •

edited

Loading

trieloff Jun 21, 2024

kptdobe Jun 21, 2024

trieloff Jun 21, 2024

trieloff commented Jun 21, 2024

	window.addEventListener('hlx:section:loaded', sampleRUM.enhance, { once: true });
	window.addEventListener('aem:section:loaded', sampleRUM.enhance, { once: true });

	window.dispatchEvent(new CustomEvent('hlx:section:loaded', { detail: { section } }));
	window.dispatchEvent(new CustomEvent('aem:section:loaded', { detail: { section } }));

feat: use rum js v2 #371

feat: use rum js v2 #371

Conversation

kptdobe commented Jun 19, 2024

aem-code-sync bot commented Jun 19, 2024 • edited Loading

aem-code-sync bot commented Jun 19, 2024 • edited Loading

trieloff Jun 21, 2024

Choose a reason for hiding this comment

kptdobe Jun 21, 2024

Choose a reason for hiding this comment

trieloff Jun 21, 2024

Choose a reason for hiding this comment

trieloff commented Jun 21, 2024

aem-code-sync bot commented Jun 19, 2024 •

edited

Loading

aem-code-sync bot commented Jun 19, 2024 •

edited

Loading