Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add editor config #353

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Add editor config #353

merged 1 commit into from
Aug 14, 2024

Conversation

sippsolutions
Copy link
Contributor

Add editor config

@kptdobe
Copy link
Contributor

kptdobe commented Aug 13, 2024

@sippsolutions Why are you trying to patch the aem-boilerplate ?

@kptdobe kptdobe closed this Aug 13, 2024
@sippsolutions
Copy link
Contributor Author

@kptdobe because in my opinion a .editorconfig is missing that should be equivalent in all projects.
I intentionally wanted to improve the boilerplate :) Can you reopen the PR?

@kptdobe kptdobe reopened this Aug 14, 2024
@kptdobe kptdobe merged commit 2b74bad into adobe:main Aug 14, 2024
2 of 3 checks passed
@kptdobe
Copy link
Contributor

kptdobe commented Aug 14, 2024

ok, thanks. I thought linting would be enough but since it requires a npm install first, I have seen so many projects where linting is not respected and fails. Let see if .editorconfig helps.

sdmcraft added a commit to hlxsites/franklin-assets-selector that referenced this pull request Oct 10, 2024
@sdmcraft @shsteimer
@renovate @tripodsan @kptdobe @semantic-release-bot @dylandepass @fkakatie @gargadobe @buuhuu @trieloff @adobe-bot @davidnuescheler @sippsolutions @kmurugulla
Aem assets plugin (#111)
6089f96 
* add css rules to hide header and footer until they are loaded

* chore(deps): update dependency stylelint to v16.1.0 (adobe#314)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency stylelint-config-standard to v36 (adobe#315)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency chai to v5 (adobe#316)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency @babel/core to v7.23.7 (adobe#317)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency semantic-release to v23 (adobe#320)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore: update node version (adobe#321)

* chore: update node version

* chore: use node 20

* chore: get rid of semantic release (adobe#322)

* fix(lib): update scripts/aem.js to aem.js@1.5.1

Test URL: https://update-lib-aem-patch-1-5-1--aem-boilerplate--adobe.hlx.live/
Release Notes: https://github.com/adobe/aem-lib/releases/tag/v1.5.1

* chore(doc): link to cli in README (adobe#330)

* chore(deps): update dependency stylelint to v16.2.1 (adobe#324)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency chai to v5.1.0 (adobe#328)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update babel monorepo (adobe#329)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency eslint to v8.57.0 (adobe#333)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency stylelint to v16.3.1 (adobe#341)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update babel monorepo (adobe#340)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update cleanup-on-create.yaml

* Update cleanup-on-create.yaml

* Update cleanup-on-create.yaml

* chore(deps): update dependency @babel/core to v7.24.4 (adobe#342)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix: header/footer fragment loading (#13)

* chore: unify header/footer decoration

* fix(lib): update scripts/aem.js to aem.js@1.5.4

Test URL: https://update-lib-aem-patch-1-5-4--aem-boilerplate--adobe.hlx.live/
Release Notes: https://github.com/adobe/aem-lib/releases/tag/v1.5.4

* fix: cards fail if text contains an icon

* fix(404): do not include target, as it is redundant with URL

* fix: clarify eslint rules

* feat: add quote parity with eslint in stylelint

* chore: lint

* fix: remove unused rule

* fix: remove deprecated root var

* feat: added updated fonts

* fix: apply s2 font styles

* fix: increase body font size

* chore: unify color vars against s2 spec

* fix: increase color contrast between bg and link

* fix: increase contrast between link and text

* fix: unify container padding, margins, radius

* chore(deps): update dependency stylelint to v16.6.1 (adobe#356)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update babel monorepo to v7.24.6 (adobe#358)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency chai to v5.1.1 (adobe#360)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update babel monorepo to v7.24.7 (adobe#367)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix: link color meets background AND text contrast reqs

* chore: remove unused dep (adobe#368)

* fix: close the nav when it loses focus, e.g keyboard user tabs out of it

* fix: manual patch of sampleRUM (adobe#370)

* feat: better error tracking (adobe#375)

* feat(lib): update scripts/aem.js to aem.js@2.3.0 (adobe#378)

Test URL: https://update-lib-aem-minor-2-3-0--aem-boilerplate--adobe.hlx.live/
Release Notes: https://github.com/adobe/aem-lib/releases/tag/v2.3.0

Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>

* feat: section loader

* chore(deps): update dependency stylelint to v16.7.0 (adobe#381)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency @babel/eslint-parser to v7.24.8 (adobe#380)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency stylelint-config-standard to v36.0.1 (adobe#373)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* feat(lib): update scripts/aem.js to aem.js@2.5.0 (adobe#383)

Test URL: https://update-lib-aem-minor-2-5-0--aem-boilerplate--adobe.hlx.live/
Release Notes: https://github.com/adobe/aem-lib/releases/tag/v2.5.0

Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>

* feat: use rum js v2 (adobe#371)

* fix: a11y contrast fix

* chore: lint

* fix: a styles

* chore: lint

* chore: a11y colors

* fix: border color on cards

* fix: a11y header, ul > li role

* fix(lib): update scripts/aem.js to aem.js@2.5.1 (adobe#388)

Test URL: https://update-lib-aem-patch-2-5-1--aem-boilerplate--adobe.hlx.live/
Release Notes: https://github.com/adobe/aem-lib/releases/tag/v2.5.1

Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>

* chore(deps): update dependency @babel/eslint-parser to v7.25.1 (adobe#385)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency stylelint to v16.8.1 (adobe#386)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore: add editor config (adobe#353)

* updating url to .aem.live from .hlx.live

* docs: updating the preview and live urls in readme to .aem.page and .aem.live

* fix(lib): update scripts/aem.js to aem.js@2.5.2 (adobe#391)

Test URL: https://update-lib-aem-patch-2-5-2--aem-boilerplate--adobe.hlx.live/
Release Notes: https://github.com/adobe/aem-lib/releases/tag/v2.5.2

Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>

* chore(deps): update dependency stylelint to v16.8.2 (adobe#389)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* docs(readme): use correct AEM Live link

* chore(github): update pull request template to use aem.live

* Squashed 'plugins/aem-assets-plugin/' content from commit 2bf7be5

git-subtree-dir: plugins/aem-assets-plugin
git-subtree-split: 2bf7be5876c039f3d22fcde65401635b7410f1cc

* feat: Integrate asem-assets plugin

* Add linting exception for videojs

* Ignore videojs from linting

---------

Co-authored-by: Sean Steimer <ssteimer@adobe.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Tobias Bocanegra <tripod@adobe.com>
Co-authored-by: Alexandre Capt <acapt@adobe.com>
Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>
Co-authored-by: dylandepass <djdyland@gmail.com>
Co-authored-by: Katie Sexton <ksexton@adobe.com>
Co-authored-by: gargadobe <81246588+gargadobe@users.noreply.github.com>
Co-authored-by: Dirk Rudolph <drudolph@adobe.com>
Co-authored-by: Lars Trieloff <lars@trieloff.net>
Co-authored-by: adobe-bot <30273922+adobe-bot@users.noreply.github.com>
Co-authored-by: David Nuescheler <uncled@adobe.com>
Co-authored-by: Simon Sippert <simon.sippert@gmx.de>
Co-authored-by: Kiran Murugulla <murugull@adobe.com>
Co-authored-by: Satya Deep Maheshwari <satyam@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kptdobe kptdobe kptdobe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sippsolutions @kptdobe