Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add default value for _target (fixes #99) #100

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Conversation

swashbuck
Copy link
Contributor

@swashbuck swashbuck commented May 29, 2024

Fixes #99

Fix

  • Add default value of "_blank" for _target in example.json
  • Add default value of "_blank" for _target in properties.schema to match component.schema.json
  • Fix typo in PR template

@swashbuck swashbuck self-assigned this May 29, 2024
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@swashbuck swashbuck merged commit 9af4644 into master Jun 3, 2024
1 check passed
@swashbuck swashbuck deleted the issue/99 branch June 3, 2024 14:25
Copy link

github-actions bot commented Jun 3, 2024

🎉 This PR is included in version 6.2.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update _target in example.json as per schema requirements
4 participants