Fix: Add default value for _target (fixes #99)

adaptlearning · Jun 3, 2024 · 9af4644 · 9af4644
1 parent 9180fce
commit 9af4644
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
@@ -8,7 +8,7 @@
 * A sentence describing each fix
 
 ### Update
-* A sentence describing each udpate
+* A sentence describing each update
 
 ### New
 * A sentence describing each new feature

diff --git a/example.json b/example.json
@@ -16,7 +16,7 @@
             "small": "http://minionslovebananas.com/images/check-in-minion.jpg",
             "attribution": "Copyright © 2019",
             "_url": "",
-            "_target": ""
+            "_target": "_blank"
         },
         "_isScrollable": false,
         "_defaultScrollPercent": 0,

diff --git a/properties.schema b/properties.schema
@@ -101,7 +101,7 @@
           "type": "string",
           "required": false,
           "enum": ["_blank", "_self", "_parent", "_top"],
-          "default": "",
+          "default": "_blank",
           "title": "Target attribute",
           "inputType": {
             "type": "Select",