-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Update TinyUSB submodule commit #10559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is the latest upstream commit. There were many changes in the past the 3 months since the last submodule update. In particular, there were some fixes for descriptor parsing and better stability when devices are unplugged. See issue adafruit#10556.
Looks like some of the CI builds are failing (feather_m0_express, etc), but it's not evident to me why from looking at the action runner log. By my reading, it seems like the .uf2 files are actually getting created successfully, but then something else is going wrong? |
@samblenny Some of the larger language builds in particular boards are too big, For instance, I will look for some modules that we might turn off. For instance, on |
What did you have in mind for testing? I tried some casual stuff with code from my recent projects on a Fruit Jam board, and it seemed fine. My board collection is pretty small--mostly just RP2350, ESP32-S3, RP2040, and a little nRF52840. I have a couple SAMD21 boards, but those don't include any of the ones where the builds failed. |
@tannewt On these M0 Express boards that are overflowing, we enable |
I am thinking specifically of the USB issues that you mentioned. If it fixes those, it would be great to close them. I am not thinking we'd have to do a lot of regression testing. USB Host should be tested, of course. |
oh... that would be kind of a major research project. I'm planning to do that work, but I expect it will take a while. As it stands, I don't have good reproducers for most of the stuff I mentioned in those other "USB Host: *" issues. I've just adopted workarounds to dodge around weirdness that I stumbled on last year when I was starting all the USB host gamepad stuff. |
We often update TinyUSB without comprehensive testing. I was just hoping you could check off some known issues, like the plug/unplug one, etc. |
For that one, there are two different things going on. My unplug issue is about ambiguity in |
I tested my firmware build for this PR to see if it helps with USB Host: Fast polling + write to CIRCUITPY crashes board #10562, but it doesn't seem to make any difference. |
I tested my firmware build for this PR to see if it helps with USB Host: Unplugging device can break usb.core.find() #10563, but it doesn't seem to make any difference. |
I'm not sure you can disable any of these without removing functionality. They all have enough pins for parallel. I can take a look to see what is still enabled. |
Turn off |
(as suggested by tannewt in issue adafruit#10556)
As suggested by tannewt in PR adafruit#10559, this turns off codeop for Feather M0 and errno for the Metro M0 and Redboard Turbo. This is trying to free up enough space to fit the latest TinyUSB and Pico-PIO-USB submodule updates.
Disabled codeop for Feather M0 and errno for Metro M0 and Redboard. Also bumped the Pico-PIO-USB submodule version. Checks passed with all CI builds successful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This is the latest upstream TinyUSB commit. There were many changes in the past 3 months since the last submodule update. In particular, there were some fixes for descriptor parsing and better stability when devices are unplugged. See issue #10556.
Checks:
make -j BOARD=adafruit_fruit_jam
worked fineAs Dan mentioned in the related issue, this will need more testing for other boards.