match cpython recv timeout behavior. new httpserver example #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # adafruit_wiznet5k/adafruit_wiznet5k_socket.py
|
Most of this was also done in #139. with the latest commits I've merged main and resolved conflicts as well as one tweak that resolves #141 so that the library can be successfully initialized. Re-tested successfully on a Feather RP2040 although I've noticed with my setup it consistently fails if my ethernet featherwing is connected to an ethernet switch rather than directly to the router. I have a PC and RasPi on that same switch that work fine but the microcontroller + Ethernet featherwing and this library do not. I suspect that is something specific to my environment and not an issue with this library. |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jan 30, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 5.0.6 from 5.0.5: > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#125 from FoamyGuy/recv_timeout Updating https://github.com/adafruit/Adafruit_CircuitPython_HTTPServer to 4.5.1 from 4.5.0: > Merge pull request adafruit/Adafruit_CircuitPython_HTTPServer#76 from michalpokusa/routes-refactor Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 7.5.8 from 7.5.6: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#199 from vladak/loop_vs_keep_alive > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#200 from vladak/loop_timeout_vs_socket_timeout > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#184 from rjauquet/rej-fix-loop-blocking Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 1.0.0 from 0.8.2: > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#61 from Gebhartj/Gebhartj-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has two primary chagnes:
This change is necessary in order to have the MiniMQTT library function as expected. Without this change when you call mqtt_client.loop() it will never return until actual data has been recieved. But it should be returning sooner based on the timeout behavior when there is no data.
This comment: adafruit/Adafruit_CircuitPython_ESP32SPI#167 (comment) contains CPython code snippets that illustrate the timeout behavior of the socket. The changes in this PR will make the wiznet socket behave the same.
The CPython socket has a custom exception class called
timeoutwhich I've added as well. There were a few other unrelated function arguments that already had the nametimeoutso pylint started complaining about overwriting from outer scope. I've changed those arguments to have leading underscores.I tested this change succesfully using an Ethernet Featherwing with a Feather ESP32-S3 TFT
8.2.0-beta.0I tested with simpletest, simpleserver, and aio_post examples from this repo, the ethernet adafruitio example in the MiniMQTT library, as well as the new HTTPServer example added and explained below.