Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repair inscorect directive .offset to .origin #61

Merged
merged 2 commits into from
Jan 26, 2024
Merged

repair inscorect directive .offset to .origin #61

merged 2 commits into from
Jan 26, 2024

Conversation

Gebhartj
Copy link
Contributor

.offset directive do not exist in pioasm

@Gebhartj
repair inscorect directive .offset to .origin
6ac60b4 
.offset directive do not exist in pioasm
@Gebhartj
Copy link
Contributor Author

Some tests failed, but i can not see .offset directive in official datashet https://datasheets.raspberrypi.com/rp2040/rp2040-datasheet.pdf#page=318

@tannewt tannewt requested a review from jepler January 24, 2024 18:14
@jepler
Copy link
Member

jepler commented Jan 26, 2024

Besides the code in here we need to check though other code in bundle and learn that might use the incorrect name for this directive. Otherwise, looks good

jepler
jepler approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked learn and adafruit bundle and didn't find any uses of this directive. I found my own use of this directive, so I'll have to change some of my code.

@jepler jepler merged commit fcc52f3 into adafruit:main Jan 26, 2024
1 check passed
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jan 30, 2024
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@38b61d2)
3762c50 
Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 5.0.6 from 5.0.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#125 from FoamyGuy/recv_timeout

Updating https://github.com/adafruit/Adafruit_CircuitPython_HTTPServer to 4.5.1 from 4.5.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_HTTPServer#76 from michalpokusa/routes-refactor

Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 7.5.8 from 7.5.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#199 from vladak/loop_vs_keep_alive
  > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#200 from vladak/loop_timeout_vs_socket_timeout
  > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#184 from rjauquet/rej-fix-loop-blocking

Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 1.0.0 from 0.8.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#61 from Gebhartj/Gebhartj-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jepler jepler jepler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gebhartj @jepler