Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Missing Type Annotations #14

Merged
merged 3 commits into from
Sep 8, 2022
Merged

Add Missing Type Annotations #14

merged 3 commits into from
Sep 8, 2022

Conversation

tcfranks
Copy link
Contributor

@tcfranks tcfranks commented Sep 7, 2022

resolves #10
submitted for review / comment

@tekktrik tekktrik requested a review from a team September 7, 2022 16:57
adafruit_tfmini.py Outdated Show resolved Hide resolved
adafruit_tfmini.py Outdated Show resolved Hide resolved
adafruit_tfmini.py Outdated Show resolved Hide resolved
adafruit_tfmini.py Outdated Show resolved Hide resolved
adafruit_tfmini.py Outdated Show resolved Hide resolved
@tcfranks
Copy link
Contributor Author

tcfranks commented Sep 8, 2022

resubmitted with changes

Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change:

adafruit_tfmini.py Outdated Show resolved Hide resolved
@tcfranks
Copy link
Contributor Author

tcfranks commented Sep 8, 2022

removed constant names as indicated

Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tekktrik tekktrik merged commit 93d1c7d into adafruit:main Sep 8, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Sep 9, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_TFmini to 1.2.15 from 1.2.14:
  > Merge pull request adafruit/Adafruit_CircuitPython_TFmini#14 from tcfranks/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_TLV493D to 2.0.0 from 1.2.13:
  > Merge pull request adafruit/Adafruit_CircuitPython_TLV493D#16 from BrianPugh/patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_asyncio to 0.5.16 from 0.5.15:
  > Merge pull request adafruit/Adafruit_CircuitPython_asyncio#28 from tekktrik/dev/fix-ci
  > Merge pull request adafruit/Adafruit_CircuitPython_asyncio#26 from dedukun/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_HID to 5.3.3 from 5.3.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_HID#104 from adafruit/typing-improvements
  > Merge pull request adafruit/Adafruit_CircuitPython_HID#103 from adafruit/dont-crash-on-full
  > Merge pull request adafruit/Adafruit_CircuitPython_HID#101 from adafruit/fix-import-python3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Type Annotations
2 participants