Typing improvements #104
Merged
Typing improvements #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. for compatibility, find_device can take a single device as well as a sequence of devices. However, the static type info only permits the sequence form. This quiets the mypy diagnostic without adding any extra bytecode to mpy files
.. and anyway the type is actually a Tuple when using usb_hid.devices in CircuitPython. This has a small cost in mpy file size but not as much as we earned back with earlier optimizations. The over-broad exception is used in order to reduce byte code growth
tekktrik
reviewed
Sep 6, 2022
tekktrik
approved these changes
Sep 7, 2022
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Sep 9, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_TFmini to 1.2.15 from 1.2.14: > Merge pull request adafruit/Adafruit_CircuitPython_TFmini#14 from tcfranks/main Updating https://github.com/adafruit/Adafruit_CircuitPython_TLV493D to 2.0.0 from 1.2.13: > Merge pull request adafruit/Adafruit_CircuitPython_TLV493D#16 from BrianPugh/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_asyncio to 0.5.16 from 0.5.15: > Merge pull request adafruit/Adafruit_CircuitPython_asyncio#28 from tekktrik/dev/fix-ci > Merge pull request adafruit/Adafruit_CircuitPython_asyncio#26 from dedukun/main Updating https://github.com/adafruit/Adafruit_CircuitPython_HID to 5.3.3 from 5.3.2: > Merge pull request adafruit/Adafruit_CircuitPython_HID#104 from adafruit/typing-improvements > Merge pull request adafruit/Adafruit_CircuitPython_HID#103 from adafruit/dont-crash-on-full > Merge pull request adafruit/Adafruit_CircuitPython_HID#101 from adafruit/fix-import-python3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.