fix recv_into for larger fetches #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 28, 2022
Merged
dhalbert
added a commit
to dhalbert/Adafruit_CircuitPython_ESP32SPI
that referenced
this pull request
Jun 1, 2022
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jun 2, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_DS1307 to 2.1.11 from 2.1.10: > Merge pull request adafruit/Adafruit_CircuitPython_DS1307#25 from tekktrik/doc/add-typing > Set language to "en" for documentation > Switch to inclusive terminology > Increase min lines similarity Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 4.2.2 from 4.2.1: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#166 from dhalbert/fix-recv_into > Set language to "en" for documentation > Switch to inclusive terminology > Increase min lines similarity
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #165. Rewrote
socket._recv_intoto remove superfluous code (received) and fix buffer, length, and index calculations.This fix only fixes #165. I am still seeing some other oddities, like a few-second delay on some fetches. After this PR is merged to fix this current major version, I have another PR to start to revamp this library more thoroughly.
Informing original reporter here: https://forums.adafruit.com/viewtopic.php?f=60&t=189508