Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type annotations #25

Merged
merged 1 commit into from
Jun 1, 2022
Merged

Add type annotations #25

merged 1 commit into from
Jun 1, 2022

Conversation

tekktrik
Copy link
Member

@tekktrik tekktrik commented Jun 1, 2022

Resolves #23 by adding type annotations!

@tekktrik tekktrik requested a review from a team June 1, 2022 03:36
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@dhalbert dhalbert merged commit d450a5d into adafruit:main Jun 1, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jun 2, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_DS1307 to 2.1.11 from 2.1.10:
  > Merge pull request adafruit/Adafruit_CircuitPython_DS1307#25 from tekktrik/doc/add-typing
  > Set language to "en" for documentation
  > Switch to inclusive terminology
  > Increase min lines similarity

Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 4.2.2 from 4.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#166 from dhalbert/fix-recv_into
  > Set language to "en" for documentation
  > Switch to inclusive terminology
  > Increase min lines similarity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Type Annotations
2 participants