gemspec: Dont force nokogiri lesser than 1.6.0 #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nokogiri drop support for Ruby 1.8 with nokogiri 1.6.0. It fix a lot of bugs with libxml2 and others. * sparklemotion/nokogiri@7c5f3f6 And force a user to downgrade his nokogiri version is not very friendly to a project that want to be up-to-date. ref #765
jduff
added a commit
that referenced
this pull request
Aug 22, 2013
gemspec: Dont force nokogiri lesser than 1.6.0
jhawthorn
pushed a commit
to StemboltHQ/active_merchant
that referenced
this pull request
Sep 5, 2013
Partially reverts f09138e References activemerchant#813, activemerchant#765, activemerchant#815
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nokogiri drop support for Ruby 1.8 with nokogiri 1.6.0.
It fix a lot of bugs with libxml2 and others.
And force a user to downgrade his nokogiri version is not very friendly to
a project that want to be up-to-date.
ref #765