Bump nokogiri to ~> 1.6.0 #765
Comments
|
👍 |
|
Please create a pull request for us to take a look at if this interests you. |
jhawthorn
pushed a commit
to StemboltHQ/active_merchant
that referenced
this issue
Sep 5, 2013
Partially reverts f09138e References activemerchant#813, activemerchant#765, activemerchant#815
chengz
pushed a commit
to chengz/active_merchant
that referenced
this issue
Dec 7, 2013
Nokogiri drop support for Ruby 1.8 with nokogiri 1.6.0. It fix a lot of bugs with libxml2 and others. * sparklemotion/nokogiri@7c5f3f6 And force a user to downgrade his nokogiri version is not very friendly to a project that want to be up-to-date. ref activemerchant#765
NorikDavtian
added a commit
to NorikDavtian/active_merchant
that referenced
this issue
Jan 10, 2017
nokogiri gem will cause conflict later on if update rails to latest version or with other gems activemerchant#765 https://github.com/activemerchant/active_merchant/blob/master/activemerchant.gemspec#L27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Forcing it to < 1.6.0 might lead to issues as described here sparklemotion/nokogiri#829.
The current issue I experienced move the content of a page to inside the tag.
I tried to bump the gem myself but got some test failures, will investigate that and try to make those tests pass when I have more spare time. I believe that it should be fine to bump nokogiri since the only reason for setting
< 1.6.0was to support ruby 1.8 which reached end of life.The text was updated successfully, but these errors were encountered: