Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dragonwell version number parsing failed #642

Closed
4 tasks done
Accelerator1996 opened this issue Jul 1, 2024 · 3 comments
Closed
4 tasks done

Dragonwell version number parsing failed #642

Accelerator1996 opened this issue Jul 1, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@Accelerator1996
Copy link
Contributor

Accelerator1996 commented Jul 1, 2024 •
edited
Loading

Description:
Dragonwell version parsing failed. Because Dragonwell adds a few more versions to its own version number based on the upstream OpenJDK, calling semver function directly will produce an incorrect version number.

Task version:
Nightly task.

Platform:

  • Ubuntu
  • Windows

Runner type:

  • Hosted
  • Self-hosted

Expected behavior:
get correct version number.

Actual behavior:
get wrong version number, such as17.0.1.0.1+12 will be parsed to 17.0.1+0.1+12.
@Accelerator1996 Accelerator1996 added bug Something isn't working needs triage labels Jul 1, 2024
Accelerator1996 added a commit to Accelerator1996/setup-java that referenced this issue Jul 1, 2024
@Accelerator1996
Fix the bug about parsing dragonwell version(actions#642)
0ebd337
Accelerator1996 added a commit to Accelerator1996/setup-java that referenced this issue Jul 1, 2024
@Accelerator1996
Fix the bug about parsing dragonwell version (actions#642)
2f86b5b
Accelerator1996 added a commit to Accelerator1996/setup-java that referenced this issue Jul 1, 2024
@Accelerator1996
Fix the bug about parsing dragonwell version (actions#642)
28577a6
Accelerator1996 added a commit to Accelerator1996/setup-java that referenced this issue Jul 1, 2024
@Accelerator1996
Fix the bug about parsing dragonwell version (actions#642)
ec478b8
Accelerator1996 added a commit to Accelerator1996/setup-java that referenced this issue Jul 1, 2024
@Accelerator1996
Fix the bug about parsing dragonwell version (actions#642)
09a2bd4
Accelerator1996 added a commit to Accelerator1996/setup-java that referenced this issue Jul 1, 2024
@Accelerator1996
Fix the bug about parsing dragonwell version (actions#642)
a3c03fb
@Accelerator1996 Accelerator1996 mentioned this issue Jul 1, 2024
Merged
2 tasks
@HarithaVattikuti
Copy link
Contributor

Hello @Accelerator1996
Thank you for creating this issue. We will investigate it and get back to you as soon as we have some feedback.

@esaulpaugh
Copy link

https://github.com/esaulpaugh/headlong/actions/runs/9800088963/job/27061442613

Accelerator1996 added a commit to Accelerator1996/setup-java that referenced this issue Jul 18, 2024
@Accelerator1996
Fix the bug about parsing dragonwell version (actions#642)
d1fc000
Accelerator1996 added a commit to Accelerator1996/setup-java that referenced this issue Jul 18, 2024
@Accelerator1996
Fix the bug about parsing dragonwell version (actions#642)
2145813
Accelerator1996 added a commit to Accelerator1996/setup-java that referenced this issue Jul 19, 2024
@Accelerator1996
Fix the bug about parsing dragonwell version (actions#642)
707d85c
Accelerator1996 added a commit to Accelerator1996/setup-java that referenced this issue Jul 24, 2024
@Accelerator1996
Fix the bug about parsing dragonwell version (actions#642)
7b53896
Accelerator1996 added a commit to Accelerator1996/setup-java that referenced this issue Jul 24, 2024
@Accelerator1996
Fix the bug about parsing dragonwell version (actions#642)
205bf16
mhoffrog pushed a commit to GHCICD/setup-java that referenced this issue Jul 28, 2024
@Accelerator1996 @mhoffrog
Fix the bug about parsing dragonwell version (actions#642)
5fe1ac0
mhoffrog pushed a commit to GHCICD/setup-java that referenced this issue Jul 28, 2024
@Accelerator1996 @mhoffrog
Fix the bug about parsing dragonwell version (actions#642)
2debda0
HarithaVattikuti pushed a commit that referenced this issue Aug 1, 2024
@Accelerator1996
Fix the bug about parsing dragonwell version (#642) (#643)
6a0805f
@aparnajyothi-y
Copy link
Contributor

Hello @Accelerator1996, This issue is fixed with this PR merge hence proceeding to this issue.
Please feel free to reach us in case of any further concerns to reopen this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@esaulpaugh @Accelerator1996 @HarithaVattikuti @aparnajyothi-y and others