Skip to content

Commit

Permalink
Fix the bug about parsing dragonwell version (actions#642)
Browse files Browse the repository at this point in the history
  • Loading branch information
Accelerator1996 committed Jul 18, 2024
1 parent fd08b9c commit 2145813
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 2 deletions.
5 changes: 4 additions & 1 deletion dist/setup/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -124232,7 +124232,10 @@ class DragonwellDistribution extends base_installer_1.JavaBase {
// Some version of Dragonwell JDK are numerated with help of non-semver notation (more then 3 digits).
// Common practice is to transform excess digits to the so-called semver build part, which is prefixed with the plus sign, to be able to operate with them using semver tools.
if (jdkVersion.split('.').length > 3) {
jdkVersion = (0, util_1.convertVersionToSemver)(jdkVersion);
const jdkVersionNums = jdkVersion
.replace('+', '.')
.split('.');
jdkVersion = (0, util_1.convertVersionToSemver)(`${jdkVersionNums.slice(0, 3).join('.')}.${jdkVersionNums[jdkVersionNums.length - 1]}`);
}
for (const edition in archMap) {
eligibleVersions.push({
Expand Down
9 changes: 8 additions & 1 deletion src/distributions/dragonwell/installer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,14 @@ export class DragonwellDistribution extends JavaBase {
// Some version of Dragonwell JDK are numerated with help of non-semver notation (more then 3 digits).
// Common practice is to transform excess digits to the so-called semver build part, which is prefixed with the plus sign, to be able to operate with them using semver tools.
if (jdkVersion.split('.').length > 3) {
jdkVersion = convertVersionToSemver(jdkVersion);
const jdkVersionNums: string[] = jdkVersion
.replace('+', '.')
.split('.');
jdkVersion = convertVersionToSemver(
`${jdkVersionNums.slice(0, 3).join('.')}.${
jdkVersionNums[jdkVersionNums.length - 1]
}`
);
}

for (const edition in archMap) {
Expand Down

0 comments on commit 2145813

Please sign in to comment.