fix: add style block for Cf helper #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
redonkulus
commented
Jul 21, 2022
| @@ -258,6 +243,13 @@ | |||
| .W\(9\/12\) { | |||
| width: 75%; | |||
| } | |||
| .Cf:before, .Cf:after { | |||
There was a problem hiding this comment.
Classes correctly added back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I confirm that this contribution is made under a BSD license and that I have the authority necessary to make this contribution on behalf of its copyright owner.
Description
When I changed the
Cfhelper class to remove the IE hacks, I removed thestyleblock which apparently is required to add the:afterand:beforestyles. Without this theCfclass was not added in the atomic output.Motivation and Context
Missing
Cfclass breaks layouts.How Has This Been Tested?
Tested on the example site by adding
Cfclass. Also tested that adding the generatedCfstyles to a production site fixed the layout issue.Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply: