-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove --ie feature support #448
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -42,7 +42,7 @@ program | |
.option('--exclude [pattern]', 'excluded file pattern', collect, []) | ||
.option('--rtl', 'swaps `start` and `end` keyword replacements with `right` and `left`') | ||
.option('--bump-mq', 'increases specificity of media queries a small amount') | ||
.option('--ie', 'adds old IE hacks to the output') | ||
.option('--ie', '[deprecated] no longer used') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removing this option completely, breaks the command, so leaving it for now |
||
.option('--verbose', 'show additional log info (warnings)') | ||
.option('--quiet', 'hide processing info') | ||
.parse(process.argv); | ||
|
@@ -204,11 +204,6 @@ if (typeof programOpts.helpersNamespace !== 'undefined') { | |
options.helpersNamespace = programOpts.helpersNamespace; | ||
} | ||
|
||
// Options: IE | ||
if (typeof programOpts.ie !== 'undefined') { | ||
options.ie = true; | ||
} | ||
|
||
if (programOpts.watch && programOpts.watch.length) { | ||
var buildTriggerState = { files: {} }; | ||
var watcher = chokidar.watch(programOpts.watch) | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -147,9 +147,7 @@ module.exports = [ | |
'noParams': true, | ||
'styles': { | ||
'display': 'table-cell', | ||
'width': '1600px', /* 1 */ | ||
'*width': 'auto', | ||
'zoom': 1 | ||
'width': '1600px' /* 1 */ | ||
} | ||
}, | ||
/** | ||
|
@@ -164,9 +162,6 @@ module.exports = [ | |
'link': 'https://acss.io/guides/helper-classes.html#-cf-clearfix-', | ||
'matcher': 'Cf', | ||
'noParams': true, | ||
'styles': { | ||
'zoom': 1 | ||
}, | ||
'rules': { | ||
'.Cf:before, .Cf:after': { | ||
'content': '" "', | ||
|
@@ -224,7 +219,6 @@ module.exports = [ | |
'noParams': true, | ||
'styles': { | ||
'position': 'absolute !important', | ||
'*clip': 'rect(1px 1px 1px 1px)', | ||
'clip': 'rect(1px,1px,1px,1px)', | ||
'padding': '0 !important', | ||
'border': '0 !important', | ||
|
@@ -248,8 +242,6 @@ module.exports = [ | |
'noParams': true, | ||
'styles': { | ||
'display': 'inline-block', | ||
'*display': 'inline', | ||
'zoom': 1, | ||
'vertical-align': 'top' | ||
} | ||
}, | ||
|
@@ -283,9 +275,7 @@ module.exports = [ | |
}, | ||
'a[class*=LineClamp]': { | ||
'display': 'inline-block', | ||
'display ': '-webkit-box', | ||
'*display': 'inline', | ||
'zoom': 1 | ||
'display ': '-webkit-box' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @thierryk @carriemorrison There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Is it? /s
They made a mess when they introduced vendor prefixes. i.e., MS Edge supports I'd leave things the way they are though as this original Better would be to revisit the styling/declarations in that "helper" class to use the new stuff now that we have |
||
}, | ||
/** | ||
* Fix WebKit bug that displays ellipsis in middle of text inside *LINKS* | ||
|
@@ -322,10 +312,7 @@ module.exports = [ | |
'display': 'inline-block', | ||
'vertical-align': 'top', | ||
'width': '100%', | ||
'box-sizing': 'border-box', | ||
'*display': 'block', | ||
'*width': 'auto', | ||
'zoom': 1 | ||
'box-sizing': 'border-box' | ||
} | ||
}, | ||
/** | ||
|
@@ -348,22 +335,5 @@ module.exports = [ | |
'bottom': 0, | ||
'left': 0 | ||
} | ||
}, | ||
/** | ||
================================================================== | ||
Zoom | ||
hack for oldIE to create a "block-formatting context" | ||
================================================================== | ||
*/ | ||
{ | ||
'type': 'helper', | ||
'name': 'Zoom', | ||
'description': "Gives a box 'layout' in old versions of Internet Explorer", | ||
'link': 'https://acss.io/guides/helper-classes.html#-zoom-', | ||
'matcher': 'Zoom', | ||
'noParams': true, | ||
'styles': { | ||
'zoom': '1' | ||
} | ||
} | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@src-code I'm not sure why this collapsed into one rule