-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump ethers & typechain #288
Changes from all commits
4980596
f45f236
7209f7a
33f69ce
abe7f31
65c2731
e34bff4
67a343a
9cafdbb
0e3dd4c
cf440a9
30c8d8f
80128d4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -221,6 +221,7 @@ describe("SpokePool Slow Relay Logic", async function () { | |
erc20Message, | ||
0, // Should not have an applied relayerFeePct for slow relay fills. | ||
true, | ||
"9000000000000000000", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same -- how was this working before? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. My understanding is that this was pre ACX 2.5. Here's a passing test from several weeks ago: https://github.com/across-protocol/contracts-v2/actions/runs/4835389290/jobs/8617643141 |
||
] | ||
); | ||
}); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did this ever work? Do these tests pass?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep! These tests pass - below are the outputs of the calls to this function commented above.