Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump ethers & typechain #288

Merged
merged 13 commits into from
May 17, 2023
Merged

chore: bump ethers & typechain #288

merged 13 commits into from
May 17, 2023

Conversation

james-a-morris
Copy link
Contributor

@james-a-morris james-a-morris commented May 12, 2023 •
edited
Loading

Closes ACX-1121

@socket-security
Copy link

socket-security bot commented May 12, 2023 •
edited
Loading

New dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

⬆️ Updated Package Version Diff Added Capability Access +/- Transitive Count Publisher
typechain@8.1.1 5.2.0...8.1.1 None +15/-0 ethereum-ts-bot
chai@4.3.7 4.3.6...4.3.7 None +1/-1 chai
@nomiclabs/hardhat-ethers@2.2.3 2.0.5...2.2.3 None +1/-6 fvictorio
@typechain/hardhat@6.1.6 2.3.1...6.1.6 None +18/-7 ethereum-ts-bot
@eth-optimism/contracts@0.5.40 0.5.15...0.5.40 None +4/-4 optibot
@typechain/ethers-v5@10.2.1 7.2.0...10.2.1 None +16/-1 ethereum-ts-bot
@types/chai@4.3.5 4.3.0...4.3.5 None +0/-0 types

🚮 Removed packages: hardhat@2.12.1-ir.0

@james-a-morris
chore: bump ethers & typechain
4980596 
Signed-off-by: james-a-morris <jaamorris@cs.stonybrook.edu>
@james-a-morris
improve: bump typechain
f45f236 
Signed-off-by: james-a-morris <jaamorris@cs.stonybrook.edu>
@james-a-morris
improve: bump ethers hardhat
7209f7a 
Signed-off-by: james-a-morris <jaamorris@cs.stonybrook.edu>
@james-a-morris
improve: bump versions
33f69ce 
Signed-off-by: james-a-morris <jaamorris@cs.stonybrook.edu>
@james-a-morris
revert
abe7f31 
Signed-off-by: james-a-morris <jaamorris@cs.stonybrook.edu>
@james-a-morris
chore: bump versions
65c2731 
Signed-off-by: james-a-morris <jaamorris@cs.stonybrook.edu>
@james-a-morris
fix: bump hubpool
e34bff4 
Signed-off-by: james-a-morris <jaamorris@cs.stonybrook.edu>
@james-a-morris
improve: bump eth waffle
67a343a 
Signed-off-by: james-a-morris <jaamorris@cs.stonybrook.edu>
@james-a-morris
fix: modify tests
9cafdbb 
Signed-off-by: james-a-morris <jaamorris@cs.stonybrook.edu>
@james-a-morris
chore: bump chai
0e3dd4c 
Signed-off-by: james-a-morris <jaamorris@cs.stonybrook.edu>
@james-a-morris
improve: resolve utils
cf440a9 
Signed-off-by: james-a-morris <jaamorris@cs.stonybrook.edu>
@james-a-morris
chore: revert dependency
30c8d8f 
Signed-off-by: james-a-morris <jaamorris@cs.stonybrook.edu>
@linear
Copy link

linear bot commented May 16, 2023

ACX-1121 Match same ethers version of SDK/Relayer/Scraper/Contracts

For context I'm running into an issue where I need to use the SDK in the scraper API but the scraper API is using types from across contracts and initially none of them are on the same version so I'm getting a tonne of incompatibility

@james-a-morris james-a-morris requested a review from pxrl May 16, 2023 21:58
mrice32
mrice32 approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@mrice32 mrice32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

test/SpokePool.Relay.ts
@@ -682,6 +682,7 @@ async function testfillRelayWithUpdatedDeposit(depositorAddress: string) {
updatedMessage,
consts.modifiedRelayerFeePct, // Applied relayer fee % should be diff from original fee %.
false,
"0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did this ever work? Do these tests pass?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! These tests pass - below are the outputs of the calls to this function commented above.

    ✔ Can fill relay with updated fee by including proof of depositor's agreement (38ms)
    ✔ EIP1271 - Can fill relay with updated fee by including proof of depositor's agreement

test/SpokePool.SlowRelay.ts
@@ -221,6 +221,7 @@ describe("SpokePool Slow Relay Logic", async function () {
erc20Message,
0, // Should not have an applied relayerFeePct for slow relay fills.
true,
"9000000000000000000",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same -- how was this working before?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that this was pre ACX 2.5. Here's a passing test from several weeks ago: https://github.com/across-protocol/contracts-v2/actions/runs/4835389290/jobs/8617643141

@james-a-morris
chore: bump version
80128d4 
Signed-off-by: james-a-morris <jaamorris@cs.stonybrook.edu>
@james-a-morris james-a-morris merged commit 7a56413 into master May 17, 2023
@james-a-morris james-a-morris deleted the james/bump-ethers branch May 17, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrice32 mrice32 mrice32 approved these changes

@nicholaspai nicholaspai Awaiting requested review from nicholaspai nicholaspai is a code owner

@pxrl pxrl Awaiting requested review from pxrl pxrl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@james-a-morris @mrice32