Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more widely supported options for the "tr" command line utility b…y removing the use of the character class representation option. [:space:] => "\t\r\n\v\f" #2553

Merged
merged 1 commit into from
Oct 23, 2019

Conversation

master-nevi
Copy link
Contributor

@master-nevi master-nevi commented Oct 23, 2019

Reference comment: #2305 (comment)

Update to change: #2537

Original problem:

Add support for Synology routers while using dnsapi/dns_freedns.sh. Synology router scripting stacks do not have a version of the "tr" command line utility that supports character class representation option i.e. the "[:space:]" :

tr -d "[:space:]" should be replaced with tr -d "\t\r\n\v\f" inside of dnsapi/dns_freedns.sh for better support across embedded linux systems and routers.

…y removing the use of the character class representation option. [:space:] => "\t\r\n\v\f"
@Neilpang Neilpang merged commit 288049d into acmesh-official:dev Oct 23, 2019
@dkerr64
Copy link
Contributor

dkerr64 commented Oct 23, 2019

@master-nevi @Neilpang Guys, there is still a problem here. I thought I was clear. We need to include a blank space within the quoted string... tr -d " \t\r\n\v\f"
Look carefully and you will see a blank space after the first quote. This was missing from this PR you merged. If you want me to do it then that is fine, but I cannot do it until next week as I am traveling.

Neilpang pushed a commit that referenced this pull request Oct 24, 2019
@Neilpang
Copy link
Member

Done.

@dkerr64
Copy link
Contributor

dkerr64 commented Oct 25, 2019

Done.

Thank you @Neilpang though you also need to do it at line 352 as well as 306...
https://github.com/Neilpang/acme.sh/blob/18ad01533b3b5d0cf51f9e72464940e7a080d880/dnsapi/dns_freedns.sh#L352

Neilpang pushed a commit that referenced this pull request Oct 25, 2019
@Neilpang
Copy link
Member

@dkerr64
fixed. thanks.

@dkerr64
Copy link
Contributor

dkerr64 commented Oct 26, 2019

@dkerr64
fixed. thanks.

@Neilpang Thank You.

@master-nevi
Copy link
Contributor Author

Thank you @Neilpang and @dkerr64 . I've verified that everything is still working as expected on my end with this latest change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants