Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more widely supported options for the "tr" command line utility in dns_freedns.sh #2537

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

master-nevi
Copy link
Contributor

@master-nevi master-nevi commented Oct 9, 2019

…by removing the use of the character class representation option. Fixes #2536

See #2536 for more info.

…y removing the use of the character class representation option. Fixes acmesh-official#2536
@Neilpang Neilpang merged commit d035cdc into acmesh-official:dev Oct 10, 2019
@dkerr64
Copy link
Contributor

dkerr64 commented Oct 23, 2019

This should be updated to also remove tabs and spaces as well, and maybe even vertical tabs and form feeds. While things may be working just fine now, the subsequent greps and seds assume that spaces have been removed. FreeDNS does not presently have spaces in places that the code is sensitive to, but if that changed in the future this would fail. Hence if "[:space:]" won't work then I would replace with " \r\n\t\v\f" (note blank space within the string)
David

@dkerr64
Copy link
Contributor

dkerr64 commented Oct 23, 2019

Correction to my previous comment. You DO NEED to explicitly have a space character in the string as there ARE spaces that need to be removed for later greps to work. I recommend reverting this pull request and replacing the tr string with " \r\n\t\v\f" (note blank space within the string)

@Neilpang
Copy link
Member

@dkerr64
Sorry, please create a new PR to fix it.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants