-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tools] Implement lorisInstance in tools directory #9397
base: main
Are you sure you want to change the base?
[tools] Implement lorisInstance in tools directory #9397
Conversation
@victori444 Assigning to you to resolve conflicts and then I'll test / review! |
does this resolve the issue listed or only partially resolve it? (There are many places listed in the issue and merging it with "Resolved" will close the issue automatically) |
According to the comments of the issue, these were the only 2 remaining out of the initial list |
4b6a810
to
11e3717
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting this error when running:
(base) lorisadmin@cbeaudoin-dev:/var/www/loris/tools$ php detect_conflicts.php -r all -y
Array
(
[r] => all
[y] =>
)
Removing ignored conflictsPHP Fatal error: Uncaught Error: Cannot use object of type LORIS\Database\Query as array in /var/www/loris/tools/detect_conflicts.php:595
Stack trace:
#0 /var/www/loris/tools/detect_conflicts.php(146): detectIgnoreColumns()
#1 {main}
thrown in /var/www/loris/tools/detect_conflicts.php on line 595
588142f
to
15fa08b
Compare
Hm I don't get this error - I think this may be the error that the PR changes resolve since line 595 in the current script is where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Printing a bunch of blank lines when running this - can you check to see if that's happening for you also?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed on my end (not pushed yet) to work for linst instruments & properly detect ignored conflicts - this is to be revisited as the script may need to be optimized for memory usage |
If there are fixes needed for memory usage that sounds like a different issue. Is this ready to merge? |
Brief summary of changes
Testing instructions (if applicable)
Link(s) to related issue(s)