-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tools] Implement LorisInstance in tools directory #8058
Comments
For some reason i'm not able to edit the description properly, but fix_candidate_age.php should also be on this list instead of lorisform_parser.php twice. |
the critical ones were fixed, but there's still some other ones that need to be fixed according to @CamilleBeau.. @CamilleBeau can you give a list of which are outstanding? |
delete_ignored_conflicts.php |
I believe this has been resolved for the 2 scripts above - I will test before EOD |
Nevermind, still an issue for both:
|
Describe the bug
Plenty of tools were failing because they had not been updated to pass a LorisInstance as an argument to various functions.
The following tools were failing:
delete_ignored_conflicts.php
detect_conflicts.php
lorisform_parser.php
lorisform_parser.php
score_instrument.php
To Reproduce
Steps to reproduce the behavior (attach screenshots if applicable):
The text was updated successfully, but these errors were encountered: