Move filtermethods to apis_core.utils.filtermethods
#153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b1rger
force-pushed
the
birger/move-filters
branch
3 times, most recently
from
b9c31bf to
ffdfdfb
Compare
b1rger
force-pushed
the
birger/move-filters
branch
from
ffdfdfb to
700e7f3
Compare
b1rger
force-pushed
the
birger/move-filters
branch
3 times, most recently
from
c78950b to
1ff7073
Compare
b1rger
force-pushed
the
birger/move-filters
branch
2 times, most recently
from
344871e to
42ddec0
Compare
The apis_entities.filters.GenericEntityListFilter contained some filter methods (as defined in https://django-filter.readthedocs.io/en/main/ref/filters.html#method) and a helper method. Both could be useful to other modules. Therefore those methods are being moved out of the GenericEntityListFilter to `utils.filtermethods`. In the GenericEntityListFilter the previously defined `name` filter is not being used anymore. The function names in the `apis_core.utils.filtermethods` module were renamed and harmonized, as to not end in `_method` or `_filter`. BREAKING CHANGE: if the GenericEntityListFilter was used with the `method` set to one of the included methods, the `method` attribute should now point to `apis_core.utils.filtermethods...` Closes: #152
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
utils.filtermethodsin configurationutils.filtermethods.construct_lookupCloses: #152