Move filtermethods to apis_core.utils.filtermethods
#152
Assignees
Labels
app-entities
Anything to do with entities – the models central to an APIS app
refactor
Clean-up or restructuring of code for readability/speed/simplicity
Comments
b1rger
added
app-entities
b1rger
added a commit
that referenced
this issue
May 4, 2023
The apis_entities.filters.GenericEntityListFilter contained some filter methods (as defined in https://django-filter.readthedocs.io/en/main/ref/filters.html#method) and a helper method that could be useful to other modules. Therefore those methods are being moved to `utils.filtermethods` The `name_label_filter` method was removed, because the label module will be dropped, therefore the filter is not useful anymore. The function names in the `apis_core.utils.filtermethods` module were renamed and harmonized, as to not end in `_method` or `_filter`. Closes: #152
b1rger
added a commit
that referenced
this issue
May 4, 2023
The apis_entities.filters.GenericEntityListFilter contained some filter methods (as defined in https://django-filter.readthedocs.io/en/main/ref/filters.html#method) and a helper method that could be useful to other modules. Therefore those methods are being moved to `utils.filtermethods` The `name_label_filter` method was removed, because the label module will be dropped, therefore the filter is not useful anymore. The function names in the `apis_core.utils.filtermethods` module were renamed and harmonized, as to not end in `_method` or `_filter`. Closes: #152
b1rger
added a commit
that referenced
this issue
May 4, 2023
The apis_entities.filters.GenericEntityListFilter contained some filter methods (as defined in https://django-filter.readthedocs.io/en/main/ref/filters.html#method) and a helper method that could be useful to other modules. Therefore those methods are being moved to `utils.filtermethods` The `name_label_filter` method was removed, because the label module will be dropped, therefore the filter is not useful anymore. The function names in the `apis_core.utils.filtermethods` module were renamed and harmonized, as to not end in `_method` or `_filter`. Closes: #152
b1rger
added a commit
that referenced
this issue
May 4, 2023
The apis_entities.filters.GenericEntityListFilter contained some filter methods (as defined in https://django-filter.readthedocs.io/en/main/ref/filters.html#method) and a helper method that could be useful to other modules. Therefore those methods are being moved to `utils.filtermethods` The `name_label_filter` method was removed, because the label module will be dropped, therefore the filter is not useful anymore. The function names in the `apis_core.utils.filtermethods` module were renamed and harmonized, as to not end in `_method` or `_filter`. BREAKING CHANGE: if the GenericEntityListFilter was used with the `method` set to one of the included methods, the `method` attribute should now point to `apis_core.utils.filtermethods...` Closes: #152
b1rger
added a commit
that referenced
this issue
Jun 2, 2023
The apis_entities.filters.GenericEntityListFilter contained some filter methods (as defined in https://django-filter.readthedocs.io/en/main/ref/filters.html#method) and a helper method that could be useful to other modules. Therefore those methods are being moved to `utils.filtermethods` The `name_label_filter` method was removed, because the label module will be dropped, therefore the filter is not useful anymore. The function names in the `apis_core.utils.filtermethods` module were renamed and harmonized, as to not end in `_method` or `_filter`. BREAKING CHANGE: if the GenericEntityListFilter was used with the `method` set to one of the included methods, the `method` attribute should now point to `apis_core.utils.filtermethods...` Closes: #152
b1rger
added a commit
that referenced
this issue
Jun 2, 2023
The apis_entities.filters.GenericEntityListFilter contained some filter methods (as defined in https://django-filter.readthedocs.io/en/main/ref/filters.html#method) and a helper method that could be useful to other modules. Therefore those methods are being moved to `utils.filtermethods` The `name_label_filter` method was removed, because the label module will be dropped, therefore the filter is not useful anymore. The function names in the `apis_core.utils.filtermethods` module were renamed and harmonized, as to not end in `_method` or `_filter`. BREAKING CHANGE: if the GenericEntityListFilter was used with the `method` set to one of the included methods, the `method` attribute should now point to `apis_core.utils.filtermethods...` Closes: #152
b1rger
added a commit
that referenced
this issue
Jun 2, 2023
The apis_entities.filters.GenericEntityListFilter contained some filter methods (as defined in https://django-filter.readthedocs.io/en/main/ref/filters.html#method) and a helper method that could be useful to other modules. Therefore those methods are being moved to `utils.filtermethods` The `name_label_filter` method was removed, because the label module will be dropped, therefore the filter is not useful anymore. The function names in the `apis_core.utils.filtermethods` module were renamed and harmonized, as to not end in `_method` or `_filter`. BREAKING CHANGE: if the GenericEntityListFilter was used with the `method` set to one of the included methods, the `method` attribute should now point to `apis_core.utils.filtermethods...` Closes: #152
b1rger
added a commit
that referenced
this issue
Oct 11, 2023
The apis_entities.filters.GenericEntityListFilter contained some filter methods (as defined in https://django-filter.readthedocs.io/en/main/ref/filters.html#method) and a helper method. Both could be useful to other modules. Therefore those methods are being moved out of the GenericEntityListFilter to `utils.filtermethods`. In the GenericEntityListFilter the previously defined `name` filter is not being used anymore. The function names in the `apis_core.utils.filtermethods` module were renamed and harmonized, as to not end in `_method` or `_filter`. BREAKING CHANGE: if the GenericEntityListFilter was used with the `method` set to one of the included methods, the `method` attribute should now point to `apis_core.utils.filtermethods...` Closes: #152
b1rger
added a commit
that referenced
this issue
Oct 11, 2023
The apis_entities.filters.GenericEntityListFilter contained some filter methods (as defined in https://django-filter.readthedocs.io/en/main/ref/filters.html#method) and a helper method. Both could be useful to other modules. Therefore those methods are being moved out of the GenericEntityListFilter to `utils.filtermethods`. In the GenericEntityListFilter the previously defined `name` filter is not being used anymore. The function names in the `apis_core.utils.filtermethods` module were renamed and harmonized, as to not end in `_method` or `_filter`. BREAKING CHANGE: if the GenericEntityListFilter was used with the `method` set to one of the included methods, the `method` attribute should now point to `apis_core.utils.filtermethods...` Closes: #152
b1rger
added a commit
that referenced
this issue
Oct 11, 2023
The apis_entities.filters.GenericEntityListFilter contained some filter methods (as defined in https://django-filter.readthedocs.io/en/main/ref/filters.html#method) and a helper method. Both could be useful to other modules. Therefore those methods are being moved out of the GenericEntityListFilter to `utils.filtermethods`. In the GenericEntityListFilter the previously defined `name` filter is not being used anymore. The function names in the `apis_core.utils.filtermethods` module were renamed and harmonized, as to not end in `_method` or `_filter`. BREAKING CHANGE: if the GenericEntityListFilter was used with the `method` set to one of the included methods, the `method` attribute should now point to `apis_core.utils.filtermethods...` Closes: #152
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are a couple of filtermethods embedded in
apis_entities.filters.GenericEntityListFilter. Those filtermethods could be useful in other places, also theconstruct_lookupmethod can be useful in other custom filters. Those filtermethods should be moved toapis_core.utils.filtermethods.The text was updated successfully, but these errors were encountered: