feat/use monaco: TypeScript fixups #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cshaver
commented
Apr 27, 2020
| export namespace GraphiQL { | ||
| export type GetDefaultFieldNamesFn = (type: GraphQLType) => string[]; | ||
| export type Maybe<T> = T | null | undefined; | ||
| } |
There was a problem hiding this comment.
Whoops, I think I need to put this back?
cshaver
commented
Apr 27, 2020
| @@ -5,118 +5,111 @@ | |||
| * LICENSE file in the root directory of this source tree. | |||
| */ | |||
|
|
|||
There was a problem hiding this comment.
acao
reviewed
Apr 29, 2020
| } | ||
| } | ||
| return result; | ||
| // const { insertions, result } = fillLeafs( |
There was a problem hiding this comment.
ah yes! i think this is where we get the auto-expanding fields? trying to figure out how to re-enable that in monaco today
|
@cshaver I can port over a good portion of these changes to the current RFC branch in a PR, there's some very useful improvements here! |
acao
reviewed
Apr 30, 2020
| @@ -11,13 +11,13 @@ import type { | |||
| Diagnostic, | |||
| CompletionItem as GraphQLCompletionItem, | |||
| } from 'graphql-language-service-types'; | |||
| import type monaco from 'monaco-editor'; | |||
There was a problem hiding this comment.
it's available globally across the package now, so no need for this! i just need to add it to eslint globals
|
@cshaver I think I captured most of these improvements, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged into #17.
Doing some Sunday afternoon typescript fixes. I was curious about a couple
@ts-ignores and got carried away, so I tried to resolve all the ones I could, plus a couple spelling edits and year updates along the way.