feat: introduce monaco editor to GraphiQL #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
acao
commented
Apr 23, 2020
| }, | ||
| ); | ||
|
|
||
| // @ts-ignore | ||
| monaco.languages.graphql.graphqlDefaults.setSchemaUri(SCHEMA_URL); |
There was a problem hiding this comment.
@cshaver if we do this inside schema context, then it will reload schema and validations, completion, etc everything!!!
cshaver
reviewed
Apr 25, 2020
| @@ -0,0 +1,122 @@ | |||
| <!-- | |||
| * Copyright (c) 2019 GraphQL Contributors | |||
There was a problem hiding this comment.
Suggested change
| * Copyright (c) 2019 GraphQL Contributors | |
| * Copyright (c) 2020 GraphQL Contributors |
😛
cshaver
reviewed
Apr 26, 2020
| @@ -12,7 +13,7 @@ import JSONWorker from 'worker-loader!monaco-editor/esm/vs/language/json/json.wo | |||
| // @ts-ignore | |||
| import GraphQLWorker from 'worker-loader!monaco-graphql/esm/graphql.worker'; | |||
|
|
|||
| const SCHEMA_URL = 'https://swapi-graphql.netlify.app/.netlify/functions/index'; | |||
| const SCHEMA_URL = 'https://api.spacex.land/graphql/'; | |||
There was a problem hiding this comment.
I didn't know about this one! :D
This was referenced Apr 29, 2020
|
now that this officially improves on graphql#1468, i think it's good to merge |
cshaver
reviewed
Apr 30, 2020
Co-Authored-By: Cristina Shaver <cristina.shaver@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use-monacoloader for refs, state, etc. using default monaco json modeInstructions:
yarnfrom the monorepo root after checking out this branchyarn buildfrom the monorepo rootyarn start-graphiqlfrom the monorepo rootSupported features
Known Issues: