Add support for templates folder when packaging helm (#69) #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@abrisco or @freeformstu - I have been currently pulling this code directly from my repo as I need the functionality, but would prefer to use the bazel central registry again for this module. Would it be possible for someone to review this PR and provide feedback. Thank you. |
|
Hey! Super sorry about the absence here! I will take a look this week :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be necessary in bazel to assemble template files together into a single directory to be packaged by using something like aspect's
copy_to_directory. This commit updates the package.go to include support for path to a templates directory which would be generated bycopy_to_directory.