You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, helm_package templates require a list of all Helm template files. This approach can be problematic when you are trying to merge template files from various parts of your repo that do not match the same folder structure. For example, if I need to build a single chart that has template files in infra/charts/templates and oem/vendor/infra/charts/templates, I am currently receiving the following error: packager.go:628: Template path (oem/vendor/infra/charts/templates) does not start with templates root (infra/charts/templates).
To fix this, templates should be able to target a folder, and I see two ways to accomplish this:
Option 1) The least destructive method is to update the installHelmContent function in packager.go to determine if templatesManifest is a folder and respond accordingly.
Option 2) Change the helm_package templates to be a label that takes a path to the templates directory. This approach is a bit cleaner because it requires the user to ensure that everything is co-located properly in a templates folder when submitting.
I am happy to make the necessary changes as I am currently blocked by this issue, so please let me know your thoughts when you have a moment.
Thank you.
The text was updated successfully, but these errors were encountered:
iDiogenes
added a commit
to iDiogenes/rules_helm
that referenced
this issue
Feb 27, 2024
Hello!
Currently,
helm_package
templates require a list of all Helm template files. This approach can be problematic when you are trying to merge template files from various parts of your repo that do not match the same folder structure. For example, if I need to build a single chart that has template files ininfra/charts/templates
andoem/vendor/infra/charts/templates
, I am currently receiving the following error:packager.go:628: Template path (oem/vendor/infra/charts/templates) does not start with templates root (infra/charts/templates)
.To fix this, templates should be able to target a folder, and I see two ways to accomplish this:
Option 1) The least destructive method is to update the
installHelmContent
function inpackager.go
to determine iftemplatesManifest
is a folder and respond accordingly.Option 2) Change the
helm_package
templates to be a label that takes a path to the templates directory. This approach is a bit cleaner because it requires the user to ensure that everything is co-located properly in a templates folder when submitting.I am happy to make the necessary changes as I am currently blocked by this issue, so please let me know your thoughts when you have a moment.
Thank you.
The text was updated successfully, but these errors were encountered: