Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to protocol 1.1 #858

Merged
merged 2 commits into from
Nov 23, 2022
Merged

Revert to protocol 1.1 #858

merged 2 commits into from
Nov 23, 2022

Conversation

KacperKluka
Copy link
Contributor

We will be reverting to protocol 1.1 in order to quick-fix an urgent issue with automatic presence re-enter. The protocol will be bumped to 1.2 again once the presence issue is fixed on the client side.

This PR aims to revert the work done in #591

@KacperKluka KacperKluka self-assigned this Nov 21, 2022
@github-actions github-actions bot temporarily deployed to staging/pull/858/javadoc November 21, 2022 11:31 Inactive
Copy link
Contributor

@davyskiba davyskiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes seem reasonable, but I'm lacking knowledge to confidently say that this is a complete change 😬

Copy link
Member

@paddybyers paddybyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Automatic presence re-enter after network connection is back does not work
5 participants