Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auth_renewAuth_callback_invoked test failing with AssertionError "Callback not invoked" #863

Open
QuintinWillison opened this issue Nov 23, 2022 · 2 comments
Open

auth_renewAuth_callback_invoked test failing with AssertionError "Callback not invoked" #863

QuintinWillison opened this issue Nov 23, 2022 · 2 comments
Labels
failing-test Where an automated test is failing either locally or in CI. Perhaps flakey, wrong or bug.

Comments

@QuintinWillison
Copy link
Contributor

From this test run:

io.ably.lib.test.realtime.RealtimeAuthTest > auth_renewAuth_callback_invoked[binary_protocol] FAILED
    java.lang.AssertionError: Callback not invoked

As discussed in this Slack thread (internal) this test was added in #825 and a working theory is that this might be a regression as a result of the 1.2 to 1.1 protocol downgrade in #858.
@QuintinWillison QuintinWillison added the failing-test Where an automated test is failing either locally or in CI. Perhaps flakey, wrong or bug. label Nov 23, 2022
@sync-by-unito
Copy link

sync-by-unito bot commented Nov 23, 2022

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-2973

@QuintinWillison
Copy link
Contributor Author

Seen to fail here:

io.ably.lib.test.realtime.RealtimeSuite > io.ably.lib.test.realtime.RealtimeAuthTest.auth_renewAuth_callback_invoked[binary_protocol] FAILED
    java.lang.AssertionError: Callback not invoked
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.assertTrue(Assert.java:41)
        at io.ably.lib.test.realtime.RealtimeAuthTest.auth_renewAuth_callback_invoked(RealtimeAuthTest.java:1121)

@ikbalkaya ikbalkaya mentioned this issue Jan 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
failing-test Where an automated test is failing either locally or in CI. Perhaps flakey, wrong or bug.
Milestone
No milestone
Development

No branches or pull requests
1 participant
@QuintinWillison