LogHandler removal & logging improvements #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/340/dartdoc
github-actions
bot
temporarily deployed
to
staging/pull/340/dartdoc
ikurek
requested review from
QuintinWillison,
ikbalkaya and
lukasz-szyszkowski
ikurek
force-pushed
the
fix/log-handler-removal
branch
from
9ca4ad8 to
19de88c
Compare
QuintinWillison
approved these changes
Mar 2, 2022
ikbalkaya
approved these changes
Mar 4, 2022
lukasz-szyszkowski
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve #238, although it does not use the mentioned
LogHandler. Instead, the changes contain:LogHandlerentirely from Dart codeLogimplementation fromably-java. Luckily, their implementation is the same so it was only a matter of importsprintandNSLogcalls withARTLogimplementation fromably-cocoa. This was not possible everywhere, because unlikeLogfromably-javatheARTLogisn't a singleton, so I only updated a few placesWith these changes, most of the logging from Android and iOS platform native code should respect logging level set in Ably
ClientOptions.