Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LogHandler (use it) #238

Closed
ben-xD opened this issue Nov 19, 2021 · 0 comments · Fixed by #340
Closed

Fix LogHandler (use it) #238

ben-xD opened this issue Nov 19, 2021 · 0 comments · Fixed by #340
Assignees
@ikurek
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@ben-xD
Copy link
Contributor

ben-xD commented Nov 19, 2021 •
edited by sync-by-unito bot
Loading

LogHandler is an option on ClientOptions. Users can set it, but unfortunately Ably Flutter ignores it. This is because the log handler is dart code which can't be passed directly to the platform side.

We would have to store the logHandlers, and pass a handle to the Platform side instead. When Ably Cocoa and Ably Java want to use them, this would call the dart side.

┆Issue is synchronized with this Jira Bug by Unito
@ben-xD ben-xD added the bug Something isn't working. It's clear that this does need to be fixed. label Nov 19, 2021
@ben-xD ben-xD self-assigned this Nov 19, 2021
@ikurek ikurek mentioned this issue Feb 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ikurek ikurek

Labels
bug Something isn't working. It's clear that this does need to be fixed.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

LogHandler removal & logging improvements ably/ably-flutter
2 participants
@ikurek @ben-xD