docker: replace 127.0.0.1 with host gateway ip in docker daemon.json proxy settings #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….json proxy settings Refactored daemon.json to move fetching of gateway ip to a function for DRY
abiosoft
changed the title
abiosoft
previously approved these changes
Sep 28, 2024
|
I am not sure what is preventing the github actions from successfully running the virtual machines and starting Colima. |
@abiosoft I've updated the failing jobs to verbose logging, hopefully that might reveal the issue |
|
@abiosoft updated to very verbose - last ci run seems to have skipped integration, but i dont see anything on the workflow file that would cause that. do you need me do to anything specific on my end? |
|
@rteeling-evernorth it has nothing to do with your contributions. It's just Github actions acting up. |
|
@rteeling-evernorth kindly remove the verbose flags and let's get this over the line. Thanks :) |
|
@abiosoft Done. Thanks for the speedy approval! Looking forward to bringing this to my org without having to explain how to handle the proxy stuff. |
abiosoft
approved these changes
Sep 30, 2024
|
@abiosoft Thanks for moving so quickly on this. Do you have an idea of when this will be tagged/released to homebrew? |
You can already test it with I would like to figure what's going on with Github actions and get that resolved before pushing a release. In the next few days hopefully. |
|
Excellent! Thank you! |
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Nov 20, 2024
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [abiosoft/colima](https://github.com/abiosoft/colima) | minor | `v0.7.5` -> `v0.8.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>abiosoft/colima (abiosoft/colima)</summary> ### [`v0.8.0`](https://github.com/abiosoft/colima/releases/tag/v0.8.0) [Compare Source](abiosoft/colima@v0.7.6...v0.8.0) #### Highlights This is a new release to address compatibility issues with [Lima v1.0.0](https://github.com/lima-vm/lima/releases/tag/v1.0.0). - Colima now utilises virtualization.framework on macOS when Qemu is not available. Fixes [#​1188](abiosoft/colima#1188). - SSH port-forwarding is retained for Lima v1.0.0. Fixes [#​1181](abiosoft/colima#1181), [#​1184](abiosoft/colima#1184), [#​1185](abiosoft/colima#1185). #### Other Updates - Nested Virtualization is now supported with the `--nested-virtualization` flag or `nestedVirtualization` config for m3 devices. - The default disk size is now 100GiB. #### Commits - core: retain SSH port forwarder by [@​abiosoft](https://github.com/abiosoft) in abiosoft/colima#1182 - core: make qemu an optional dependency by [@​abiosoft](https://github.com/abiosoft) in abiosoft/colima#1187 **Full Changelog**: abiosoft/colima@v0.7.6...v0.8.0 ### [`v0.7.6`](https://github.com/abiosoft/colima/releases/tag/v0.7.6) [Compare Source](abiosoft/colima@v0.7.5...v0.7.6) #### Highlights This release introduces the `colima update` command to update the container runtime version (e.g. Docker version) without needing to upgrade Colima or wait for the next release. #### Other Fixes - Avoid error when docker-certs directory does not exist. Fixes [#​1128](abiosoft/colima#1128). - Update host-gateway-ip in proxy settings for docker daemon. Fixes [#​956](abiosoft/colima#956), [#​1040](abiosoft/colima#1040). #### Commits - docker: avoid error where the cache docker-certs directory does not exist by [@​AlexanderOMara](https://github.com/AlexanderOMara) in abiosoft/colima#1129 - build(deps): bump golang.org/x/term from 0.23.0 to 0.24.0 by [@​dependabot](https://github.com/dependabot) in abiosoft/colima#1133 - docs: fixed typo on Apple Silicon in README by [@​analogsignals](https://github.com/analogsignals) in abiosoft/colima#1137 - docker: replace 127.0.0.1 with host gateway ip in docker daemon.json proxy settings by [@​rteeling-evernorth](https://github.com/rteeling-evernorth) in abiosoft/colima#1145 - ci: bump Go version by [@​abiosoft](https://github.com/abiosoft) in abiosoft/colima#1148 - net: update vmnet by [@​abiosoft](https://github.com/abiosoft) in abiosoft/colima#1152 - build(deps): bump golang.org/x/term from 0.24.0 to 0.25.0 by [@​dependabot](https://github.com/dependabot) in abiosoft/colima#1154 - Minor updates by [@​abiosoft](https://github.com/abiosoft) in abiosoft/colima#1156 - ci: use older qemu version by [@​abiosoft](https://github.com/abiosoft) in abiosoft/colima#1160 - build(deps): bump github.com/fatih/color from 1.17.0 to 1.18.0 by [@​dependabot](https://github.com/dependabot) in abiosoft/colima#1171 - cli: add update command by [@​abiosoft](https://github.com/abiosoft) in abiosoft/colima#1178 - core: update disk images by [@​abiosoft](https://github.com/abiosoft) in abiosoft/colima#1179 #### New Contributors - [@​AlexanderOMara](https://github.com/AlexanderOMara) made their first contribution in abiosoft/colima#1129 - [@​analogsignals](https://github.com/analogsignals) made their first contribution in abiosoft/colima#1137 - [@​rteeling-evernorth](https://github.com/rteeling-evernorth) made their first contribution in abiosoft/colima#1145 **Full Changelog**: abiosoft/colima@v0.7.5...v0.7.6 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1144
Related to #956, #1040