Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile with -Weverything flag #68

Closed
3 tasks done
abbeycode opened this issue Oct 13, 2017 · 1 comment
Closed
3 tasks done

Compile with -Weverything flag #68

abbeycode opened this issue Oct 13, 2017 · 1 comment
Assignees
@abbeycode
Labels
enhancement
Milestone
1.9

Comments

@abbeycode
Copy link
Owner

abbeycode commented Oct 13, 2017 •
edited
Loading

This produces a ton of warnings, but the problem is I don't want any warnings reported for the minizip library. I can solve this by moving the minizip library into its own static library that'll get compiled in. Then I'll specify -Weverything for UnzipKit, and -Wnone for minizip. This was implemented in abbeycode/UnrarKit#56

  • Split minizip into its own library, linked into UnzipKit
  • Specify -Weverything for UnrarKit
  • Fix all warnings produced
@abbeycode
Copy link
Owner Author

Turns out -Weverything was already turned on, but it was configured differently for debug and release configurations, and the minizip warnings were being ignored globally. So this turned into a simplification of the warning configuration.

@abbeycode abbeycode mentioned this issue Oct 15, 2017
Merged
@abbeycode abbeycode added this to the 1.9 milestone Oct 15, 2017
@abbeycode abbeycode self-assigned this Oct 15, 2017
abbeycode added a commit that referenced this issue Oct 16, 2017
@abbeycode
Hide warnings in minizip, not UnzipKit (#71)
b08b3ee 
Implemented Issue #68, reworking how errors are represented
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abbeycode abbeycode

Labels
enhancement
Projects
None yet
Milestone
1.9
Development

No branches or pull requests
1 participant
@abbeycode