Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile with -Weverything flag #56

Closed
3 tasks done
abbeycode opened this issue Sep 29, 2017 · 1 comment
Closed
3 tasks done

Compile with -Weverything flag #56

abbeycode opened this issue Sep 29, 2017 · 1 comment
Assignees
@abbeycode
Labels
enhancement
Milestone
2.9

Comments

@abbeycode
Copy link
Owner

abbeycode commented Sep 29, 2017 •
edited
Loading

This produces a ton of warnings, but the problem is I don't want any warnings reported for the unrar library. I can solve this by moving the unrar library into its own static library that'll get compiled in, I think. Then I'll specify -Weverything for UnrarKit, and -Wnone for unrar. This makes sense after #55, since it involves changing target configuration around.

  • Split unrar into its own library, linked into UnrarKit
  • Specify -Weverything for UnrarKit
  • Fix all warnings produced
@abbeycode abbeycode self-assigned this Sep 29, 2017
@abbeycode abbeycode changed the title Compile with -Weverything Compile with -Weverything flag Oct 4, 2017
@abbeycode abbeycode mentioned this issue Oct 4, 2017
Merged
@abbeycode abbeycode added this to the 2.9 milestone Oct 4, 2017
@aonez
Copy link
Contributor

aonez commented Oct 4, 2017

Those improvements are so cool (the libunrar specifically) 👍🏼

@abbeycode abbeycode mentioned this issue Oct 13, 2017
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abbeycode abbeycode

Labels
enhancement
Projects
None yet
Milestone
2.9
Development

No branches or pull requests
2 participants
@aonez @abbeycode