Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder FFMPEG_VideoWriter command arguments #968

Merged
merged 1 commit into from
Mar 9, 2020

Conversation

ThePhonon
Copy link
Contributor

@ThePhonon ThePhonon commented Jun 4, 2019

stream options must be provided before the '-i' option to affect that stream.
The existing code caused '-an' (no audio) to be applied to the next stream. This causes no audio to be generated if the next stream is the audio stream for the clip.

e.g. On Windows:

import os
os.environ["IMAGEIO_FFMPEG_EXE"] = "path\to\newest\ffmpeg.exe"
from moviepy.editor import VideoFileClip
video = VideoFileClip("my_file_with_audio.mp4").subclip(0, 10)
video.write_videofile("created_clip.mp4")

will generate a video file with no audio.

  • If this is a bugfix, I have provided code that clearly demonstrates the problem and that works when used with this PR
  • I have added a test to the test suite, if necessary
  • I have properly documented new or changed features in the documention, or the docstrings
  • I have properly documented unusual changes to the code in the comments around it
  • I have made note of any breaking/backwards incompatible changes

stream options must be provided before the '-i' option to affect that stream.
The existing code caused '-an' (no audio) to be applied to the next stream.  This causes no audio to be generated if the next stream is the audio stream for the clip.
@ThePhonon ThePhonon mentioned this pull request Jun 4, 2019
5 tasks
@berndf berndf mentioned this pull request Sep 12, 2019
@tburrows13 tburrows13 changed the title Update ffmpeg_writer.py Reorder FFMPEG_VideoWriter command arguments Feb 23, 2020
@tburrows13 tburrows13 added bug-fix For PRs and issues solving bugs. lib-FFmpeg Issues pertaining to dependency FFmpeg. labels Feb 24, 2020
@tburrows13 tburrows13 added this to the Release v1.0.2 milestone Feb 24, 2020
@tburrows13
Copy link
Collaborator

Closes #876 #934 and possible #1032.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix For PRs and issues solving bugs. lib-FFmpeg Issues pertaining to dependency FFmpeg.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants